From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 01/13] gnu: subversion: Propagate env variables to hooks.
Date: Fri, 21 Nov 2014 23:02:29 +0100
Message-ID: <871towp5ze.fsf@gnu.org>
References: <1416548468-28421-1-git-send-email-bavier@member.fsf.org>
	<1416548468-28421-2-git-send-email-bavier@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37493)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XrwHn-0002Io-Cc
	for guix-devel@gnu.org; Fri, 21 Nov 2014 17:02:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XrwHg-0006WL-8O
	for guix-devel@gnu.org; Fri, 21 Nov 2014 17:02:39 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:36021)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XrwHg-0006WE-1g
	for guix-devel@gnu.org; Fri, 21 Nov 2014 17:02:32 -0500
In-Reply-To: <1416548468-28421-2-git-send-email-bavier@member.fsf.org> (Eric
	Bavier's message of "Thu, 20 Nov 2014 23:40:56 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

Eric Bavier <ericbavier@gmail.com> skribis:

> * gnu/packages/patches/subversion-propagate-env-to-hooks.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.
> * gnu/packages/version-control.scm (subversion): Use it.

[...]

> +++ b/gnu/packages/patches/subversion-propagate-env-to-hooks.patch
> @@ -0,0 +1,14 @@
> +* Hooks need to inherit environment variables such as PATH, otherwise si=
mple
> +  things like `ls` might fail in a hook.

What=E2=80=99s the upstream status of this patch?  I=E2=80=99m imagine it a=
 useful
property even for FHS distros.  IOW, what about submitting it upstream
if it=E2=80=99s not already done?

That looks good, but I want to make sure we=E2=80=99re not changing somethi=
ng
that was purposefully made this way.

Ludo=E2=80=99.