From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 01/01: download: Handle HTTP redirects to relative URI references. Date: Tue, 24 Feb 2015 00:44:38 -0500 Message-ID: <871tlfkgmx.fsf@netris.org> References: <20150219083234.7923.57098@vcs.savannah.gnu.org> <87h9uc4bux.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQ8IS-0004wq-KW for guix-devel@gnu.org; Tue, 24 Feb 2015 00:44:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQ8IP-0004CD-EM for guix-devel@gnu.org; Tue, 24 Feb 2015 00:44:40 -0500 In-Reply-To: <87h9uc4bux.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 23 Feb 2015 21:22:14 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > "Mark H. Weaver" skribis: > >> +;; XXX: Work around , present in Guile >> +;; up to 2.0.11. >> +(unless (or (> (string->number (major-version)) 2) >> + (> (string->number (minor-version)) 0) >> + (> (string->number (micro-version)) 11)) > > Just a minor nit: could you change that to use =E2=80=98guile-version>?= =E2=80=99 > instead? It is more concise and easier to search for. I thought about that, but it would involve importing (guix utils) from (guix build download), and then arranging to add (guix utils) to the list of imported modules in the derivation produced by 'url-fetch' in (guix download), and maybe some other places. Anyway, if we do this, we should also change the definition of 'post-2.0.7?' in the same file. Mark