From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/5] import: Add 'elpa' importer
Date: Sat, 27 Jun 2015 12:08:51 +0200
Message-ID: <871tgx31l8.fsf@gnu.org>
References: <CAKrPhPN48XUm0wXC5OakY1Wrt2Wup6WU645pBdORGpvQZFp34g@mail.gmail.com>
	<87wpyw6bjl.fsf@gmail.com>
	<CAKrPhPMuLvFtQjjz1k_pxDaCk2ZJ1NHMigi-tga9bH+t6mHu2g@mail.gmail.com>
	<87381gvmsc.fsf@gnu.org>
	<CAKrPhPN01_TRbqqjyJAEAPATSuUcwJwLDKmYDsGXOodn7LZ--g@mail.gmail.com>
	<CAKrPhPNhOFGF3jgMSX1_O_UOMowO9sMr+N+NuUnzJ+hyPfWn7Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z8n2g-0004WS-Pr
	for guix-devel@gnu.org; Sat, 27 Jun 2015 06:08:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z8n2c-0003pM-PH
	for guix-devel@gnu.org; Sat, 27 Jun 2015 06:08:58 -0400
In-Reply-To: <CAKrPhPNhOFGF3jgMSX1_O_UOMowO9sMr+N+NuUnzJ+hyPfWn7Q@mail.gmail.com>
	(Federico Beffa's message of "Sat, 27 Jun 2015 10:13:03 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>

Federico Beffa <beffa@ieee.org> skribis:

> From 56c460213d76ff2b88fd771b48997c3e03200234 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Tue, 16 Jun 2015 10:50:06 +0200
> Subject: [PATCH 1/6] import: Add 'elpa' importer.
>
> * guix/import/elpa.scm: New file.
> * guix/scripts/import.scm: Add "elpa" to 'importers'.
> * guix/scripts/import/elpa.scm: New file.
> * Makefile.am (MODULES): Add 'guix/import/elpa.scm' and
>   'guix/scripts/import/elpa.scm'.
>   (SCM_TESTS): Add 'tests/elpa.scm'.
> * doc/guix.texi (Invoking guix import): Document it.
> * tests/elpa.scm: New file.

Please add guix/scripts/import/elpa.scm to po/guix/POTFILES.in (sorry,
I had forgotten about it.)

[...]

> +(define* (call-with-downloaded-file url proc
> +                                         #:optional (err-msg "unavailabl=
e"))
> +  "Fetch URL, store the content in a temporary file and call PROC with t=
hat
> +file.  Returns the value returned by PROC."
> +     (call-with-temporary-output-file
> +      (lambda (temp port)
> +        (or (and (url-fetch url temp)
> +                 (call-with-input-file temp proc))
> +            (error err-msg url)))))

Please fix the indentation.

Remove the =E2=80=98err-msg=E2=80=99 parameter, and change the =E2=80=98err=
or=E2=80=99 call to:

  (error "download failed" url)

OK to push with these changes.

Thanks!

Ludo=E2=80=99.