From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] setbfree: Fix build on MIPS64 Date: Mon, 06 Jul 2015 09:40:18 +0200 Message-ID: <871tglka3h.fsf@elephly.net> References: <877fqejvg0.fsf@elephly.net> <878uau44rk.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC11G-0007M3-IV for guix-devel@gnu.org; Mon, 06 Jul 2015 03:40:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZC11D-0002BP-Dr for guix-devel@gnu.org; Mon, 06 Jul 2015 03:40:50 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:25078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC11D-0002Aw-2F for guix-devel@gnu.org; Mon, 06 Jul 2015 03:40:47 -0400 In-reply-to: <878uau44rk.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: Guix-devel (I failed to send this email out before the one containing a corrected patch.) >> + ;; Disable unsupported optimization flags on MIPS64 >> + ,@(if (string-prefix? "mips64" (or (%current-target-system) >> + (%current-system))) >> + '("OPTIMIZATIONS=-ffast-math -fomit-frame-pointer -O3") >> + '())) > > Can you tell what would happen on ARM systems, or other systems? > Depending on the answer to that question, it might be better to invert > the conditional and override OPTIMIZATIONS on any non-Intel system. I think you are right. The default OPTIMIZATIONS (according to common.mak) are OPTIMIZATIONS ?= -msse -msse2 -mfpmath=sse -ffast-math \ -fomit-frame-pointer -O3 -fno-finite-math-only and I think that at least the first three are only valid for x86.