From: Ricardo Wurmus <rekado@elephly.net>
To: Mark H Weaver <mhw@netris.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] setbfree: Fix build on MIPS64
Date: Mon, 06 Jul 2015 09:40:18 +0200 [thread overview]
Message-ID: <871tglka3h.fsf@elephly.net> (raw)
In-Reply-To: <878uau44rk.fsf@netris.org>
(I failed to send this email out before the one containing a corrected
patch.)
>> + ;; Disable unsupported optimization flags on MIPS64
>> + ,@(if (string-prefix? "mips64" (or (%current-target-system)
>> + (%current-system)))
>> + '("OPTIMIZATIONS=-ffast-math -fomit-frame-pointer -O3")
>> + '()))
>
> Can you tell what would happen on ARM systems, or other systems?
> Depending on the answer to that question, it might be better to invert
> the conditional and override OPTIMIZATIONS on any non-Intel system.
I think you are right. The default OPTIMIZATIONS (according to
common.mak) are
OPTIMIZATIONS ?= -msse -msse2 -mfpmath=sse -ffast-math \
-fomit-frame-pointer -O3 -fno-finite-math-only
and I think that at least the first three are only valid for x86.
prev parent reply other threads:[~2015-07-06 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 18:44 [PATCH] setbfree: Fix build on MIPS64 Ricardo Wurmus
2015-07-05 22:29 ` Mark H Weaver
2015-07-06 5:14 ` Ricardo Wurmus
2015-07-06 7:40 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tglka3h.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).