From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] Add VPN client ike.
Date: Tue, 04 Aug 2015 13:26:56 +0300
Message-ID: <871tfjpcwf.fsf@gmail.com>
References: <idjy4hsbiaz.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46899)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZMZR4-0003t8-A4
	for guix-devel@gnu.org; Tue, 04 Aug 2015 06:27:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZMZQz-0007bq-1U
	for guix-devel@gnu.org; Tue, 04 Aug 2015 06:27:06 -0400
Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:35437)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZMZQy-0007Zr-Pf
	for guix-devel@gnu.org; Tue, 04 Aug 2015 06:27:00 -0400
Received: by labsr2 with SMTP id sr2so4016844lab.2
	for <guix-devel@gnu.org>; Tue, 04 Aug 2015 03:26:57 -0700 (PDT)
In-Reply-To: <idjy4hsbiaz.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Mon, 3 Aug 2015 15:41:40 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus (2015-08-03 16:41 +0300) wrote:

> +(define-public ike
> +  (package
> +    (name "ike")
> +    (version "2.2.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://www.shrew.net/download/ike/ike-"
> +                    version "-release.tbz2"))
> +              (sha256
> +               (base32
> +                "0mvvmfc7ldgq48x75khr98d52jvg24zzlyinmzsihy2ly4g2ziq5"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; no "check" target
> +       #:out-of-source? #f
> +       #:configure-flags (list (string-append "-DSBINDIR="
> +                                              (assoc-ref %outputs "out")
> +                                              "/sbin")
> +                               (string-append "-DBINDIR="
> +                                              (assoc-ref %outputs "out")
> +                                              "/bin")
> +                               (string-append "-DETCDIR="
> +                                              (assoc-ref %outputs "out")
> +                                              "/etc")
> +                               (string-append "-DLIBDIR="
> +                                              (assoc-ref %outputs "out")
> +                                              "/lib")
> +                               (string-append "-DMANDIR="
> +                                              (assoc-ref %outputs "out")
> +                                              "/man/man1/")
> +                               "-DNATT=YES")))

It seems redundant to reevaluate (assoc-ref %outputs "out") every time.
What about wrap it into 'let'?, or maybe just to use following form:

(list (string-append "-DSBINDIR=" %output "/sbin")
      (string-append "-DBINDIR="  %output "/bin")
      (string-append "-DETCDIR="  %output "/etc")
      (string-append "-DLIBDIR="  %output "/lib")
      (string-append "-DMANDIR="  %output "/man/man1/")
      "-DNATT=YES")

-- 
Alex