From: Alex Kost <alezost@gmail.com>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add VPN client ike.
Date: Tue, 04 Aug 2015 13:26:56 +0300 [thread overview]
Message-ID: <871tfjpcwf.fsf@gmail.com> (raw)
In-Reply-To: <idjy4hsbiaz.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Mon, 3 Aug 2015 15:41:40 +0200")
Ricardo Wurmus (2015-08-03 16:41 +0300) wrote:
> +(define-public ike
> + (package
> + (name "ike")
> + (version "2.2.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://www.shrew.net/download/ike/ike-"
> + version "-release.tbz2"))
> + (sha256
> + (base32
> + "0mvvmfc7ldgq48x75khr98d52jvg24zzlyinmzsihy2ly4g2ziq5"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f ; no "check" target
> + #:out-of-source? #f
> + #:configure-flags (list (string-append "-DSBINDIR="
> + (assoc-ref %outputs "out")
> + "/sbin")
> + (string-append "-DBINDIR="
> + (assoc-ref %outputs "out")
> + "/bin")
> + (string-append "-DETCDIR="
> + (assoc-ref %outputs "out")
> + "/etc")
> + (string-append "-DLIBDIR="
> + (assoc-ref %outputs "out")
> + "/lib")
> + (string-append "-DMANDIR="
> + (assoc-ref %outputs "out")
> + "/man/man1/")
> + "-DNATT=YES")))
It seems redundant to reevaluate (assoc-ref %outputs "out") every time.
What about wrap it into 'let'?, or maybe just to use following form:
(list (string-append "-DSBINDIR=" %output "/sbin")
(string-append "-DBINDIR=" %output "/bin")
(string-append "-DETCDIR=" %output "/etc")
(string-append "-DLIBDIR=" %output "/lib")
(string-append "-DMANDIR=" %output "/man/man1/")
"-DNATT=YES")
--
Alex
next prev parent reply other threads:[~2015-08-04 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 13:41 [PATCH] Add VPN client ike Ricardo Wurmus
2015-08-04 10:26 ` Alex Kost [this message]
2015-08-13 14:10 ` Ricardo Wurmus
2015-08-18 16:00 ` Ludovic Courtès
2015-08-18 19:19 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tfjpcwf.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).