From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@openmailbox.org>
Subject: Re: [PATCH] gnu: Add python-xlrd.
Date: Thu, 01 Oct 2015 23:48:56 +0200
Message-ID: <871tdegszb.fsf@openmailbox.org>
References: <55FD6561.8050608@uq.edu.au> <87k2rmflyv.fsf@openmailbox.org>
	<87si6a5fzf.fsf@mdc-berlin.de> <877fnmno1v.fsf@openmailbox.org>
	<55FE027B.2000306@uq.edu.au> <87wpvby668.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34642)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1Zhlj3-00089k-Qf
	for guix-devel@gnu.org; Thu, 01 Oct 2015 17:49:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1Zhliz-0004N9-SN
	for guix-devel@gnu.org; Thu, 01 Oct 2015 17:49:17 -0400
Received: from smtp21.openmailbox.org ([62.4.1.55]:46619)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1Zhliz-0004ML-Lp
	for guix-devel@gnu.org; Thu, 01 Oct 2015 17:49:13 -0400
In-Reply-To: <87wpvby668.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Sun, 27 Sep 2015 22:10:39 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:
>
>> On 20/09/15 06:37, Mathieu Lirzin wrote:
>>> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>>>
>>>> Mathieu Lirzin <mthl@openmailbox.org> writes:
>>>>
>>>>>> +         ;; so use nose to run tests instead for now.
>>>>>> +         (replace 'check (lambda _ (zero? (system* "nosetests")))))=
))
>>>>>> +    (native-inputs
>>>>>> +     `(("python-setuptools" ,python2-setuptools)
>>>>>> +       ("python-nose" ,python2-nose)))
>>>>> I don't know python packaging but when I look at other packages it
>>>>> seems that these are usually used as =E2=80=9Cinputs=E2=80=9D not
>>>>> =E2=80=9Cnative-inputs=E2=80=9D.
>>>> Nose is used for the tests only and setuptools is used at build time, =
so
>>>> I think it=E2=80=99s fine like this.
>>> Is this a general statement or something specific to this package? If
>>> this is general it seems to be a good idea to make a big commit that
>>> fixes all the python packages which use these dependencies as normal
>>> inputs?  WDYT?
>> If someone were to change things wholesale, it might also be a good
>> idea to change the pypi importer to match.
>>
>> Let me know when you want me to send an updated patch - all your
>> comments look good to me Marthieu.
>
> Mathieu, Ricardo: It seems to me that this patch should go in.  The
> other issues can be discussed separately IMO; WDYT?

Pushed with the changes in 02a8a1876a9facd52fa71e76a5fdab8c97063eca

sorry for the delay. Thanks Ben.

--
Mathieu Lirzin