From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] GCJ: run libjava tests.
Date: Sun, 25 Oct 2015 22:48:35 +0100
Message-ID: <871tcik4b0.fsf@gnu.org>
References: <idjtwpjxitu.fsf@bimsb-sys02.mdc-berlin.net>
	<20151022123345.GA7846@debian>
	<idjmvvbxbp3.fsf@bimsb-sys02.mdc-berlin.net>
	<idjio5zx859.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZqT9d-0007yR-LP
	for guix-devel@gnu.org; Sun, 25 Oct 2015 17:48:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZqT9a-0005e0-Sj
	for guix-devel@gnu.org; Sun, 25 Oct 2015 17:48:41 -0400
In-Reply-To: <idjio5zx859.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Thu, 22 Oct 2015 16:58:10 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> Andreas Enge <andreas@enge.fr> writes:
>>
>>> On Thu, Oct 22, 2015 at 01:07:25PM +0200, Ricardo Wurmus wrote:
>>>>         ((#:phases phases)
>>>>          `(modify-phases ,phases
>>>> +           (replace 'check
>>>> +            (lambda _ (zero? (system* "make" "check-target-libjava"))=
))
>>>
>>> Could this be replaced by
>>>    #:test-target "check-target-libjava"
>>> ? Apart from that, your patch looks very useful.
>>
>> Ah, good idea.  I=E2=80=99m trying to build GCJ right now by adding this
>>
>>     ((#:tests? _) #t)
>>     ((#:test-target _) "check-target-libjava")
>>
>> to the =E2=80=98substitute-keyword-arguments=E2=80=99 expression instead=
 of replacing
>> the =E2=80=9Ccheck=E2=80=9D phase.  If this works I=E2=80=99ll push an u=
pdated patch.
>
> Sadly, this doesn=E2=80=99t work.  When tests are re-enabled *all* tests =
are
> run, including tests for g++, no matter what I set as a test target.
>
> I don=E2=80=99t know why.  Do you have any ideas?

=E2=80=98substitute-keyword-arguments=E2=80=99 only works if the given keyw=
ord appears
in the input:

  (substitute-keyword-arguments '()
    ((#:foo _) 'bar))

  =3D> ()

It might be what=E2=80=99s happening here?

Ludo=E2=80=99.