unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/3] emacs: Handle compiled and compressed autoloads.
Date: Fri, 11 Dec 2015 10:51:42 +0100	[thread overview]
Message-ID: <871tat9utt.fsf@gnu.org> (raw)
In-Reply-To: <87fuzaha58.fsf@gmail.com> (Alex Kost's message of "Thu, 10 Dec 2015 13:26:43 +0300")

Alex Kost <alezost@gmail.com> skribis:

> Great, I have updated and pushed 'emacs-w3m' patch.

Perfect.

> Now since it is clear that it is potentially problematic to have
> compressed *.el files, I have changed this patch to handle only compiled
> autoloads as the compressed ones are unlikely to appear ever.  OK?

Sounds good.

> From baa1950d823d0de07fa083f5f2770d3d6b681510 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Thu, 3 Dec 2015 13:03:19 +0300
> Subject: [PATCH] emacs: Handle compiled autoloads.
>
> * emacs/guix-emacs.el (guix-emacs-autoloads-regexp): New variable.
>   (guix-emacs-find-autoloads-in-directory): Return a list of autoloads
>   without extensions.

[...]

>  (defun guix-emacs-find-autoloads-in-directory (directory)
> -  "Return list of Emacs 'autoloads' files in DIRECTORY."
> -  (directory-files directory 'full-name "-autoloads\\.el\\'" 'no-sort))
> +  "Return a list of Emacs 'autoloads' files in DIRECTORY.
> +The files in the list do not have extensions (.el, .elc)."

Callers won’t have any problems with the fact that the extension is
stripped, right?

Otherwise LGTM.

Thanks,
Ludo’.

  reply	other threads:[~2015-12-11  9:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 10:39 [PATCH 0/3] Update 'emacs-w3m' and improve loading emacs autoloads Alex Kost
2015-12-06 10:39 ` [PATCH 1/3] emacs: Handle compiled and compressed autoloads Alex Kost
2015-12-07 23:00   ` Ludovic Courtès
2015-12-09  8:53     ` Alex Kost
2015-12-09 13:58       ` Ludovic Courtès
2015-12-10 10:26         ` Alex Kost
2015-12-11  9:51           ` Ludovic Courtès [this message]
2015-12-11 11:42             ` Alex Kost
2015-12-06 10:39 ` [PATCH 2/3] gnu: emacs-w3m: Use 'modify-syntax' Alex Kost
2015-12-07 23:00   ` Ludovic Courtès
2015-12-06 10:39 ` [PATCH 3/3] gnu: emacs-w3m: Update to 1.4.538+0.20141022 Alex Kost
2015-12-07 23:00   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tat9utt.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).