From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add emacs-rainbow-delimiters Date: Sun, 12 Jun 2016 17:41:21 +0300 Message-ID: <871t42sc4u.fsf@gmail.com> References: <87r3c3re1b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bC6Zt-0002ri-QR for guix-devel@gnu.org; Sun, 12 Jun 2016 10:41:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bC6Zp-0002rH-J0 for guix-devel@gnu.org; Sun, 12 Jun 2016 10:41:28 -0400 In-Reply-To: <87r3c3re1b.fsf@gnu.org> (Roel Janssen's message of "Sat, 11 Jun 2016 16:33:20 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel@gnu.org Roel Janssen (2016-06-11 17:33 +0300) wrote: > Dear Guix, > > Here's a trivial patch to add rainbow-identifiers that even makes bad > code look pretty ;). > > Is it OK to push? I think it's OK, except... > From 0725af80a8ffb923ede63ac31a61ac245a8a594b Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Sat, 11 Jun 2016 16:25:42 +0200 > Subject: [PATCH] gnu: Add emacs-rainbow-identifiers. > > * gnu/packages/emacs.scm (emacs-rainbow-identifiers): New variable. > --- > gnu/packages/emacs.scm | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 1f1d201..e7af81b 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -12,6 +12,7 @@ > ;;; Copyright =C2=A9 2016 Efraim Flashner > ;;; Copyright =C2=A9 2016 David Thompson > ;;; Copyright =C2=A9 2016 Matthew Jordan > +;;; Copyright =C2=A9 2016 Roel Janssen > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -1933,6 +1934,28 @@ matching delimiters, orient yourself in the code, = and tell which statements > are at a given level.") > (license license:gpl3+))) >=20=20 > +(define-public emacs-rainbow-identifiers > + (package > + (name "emacs-rainbow-identifiers") > + (version "0.2.2") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://raw.githubusercontent.com/Fan= ael" > + "/rainbow-identifiers/" version > + "/rainbow-identifiers.el")) > + (file-name (string-append name "-" version ".el")) ... this line should be written like this: (file-name (string-append "rainbow-identifiers-" version "= .el")) Otherwise (with your variant) the final elisp file would have "emacs-rainbow-identifiers.el" name, which is not correct: it should be named "rainbow-identifiers.el" because it provides 'rainbow-identifiers' feature. > + (sha256 > + (base32 > + "0325abxj47k0g1i8nqrq70w2wr6060ckhhf92krv1s072b3jzm31"))= )) > + (build-system emacs-build-system) > + (home-page "https://github.com/Fanael/rainbow-identifiers") > + (synopsis "Highlight identifiers in source code") > + (description > + "Rainbow identifiers mode is an Emacs minor mode providing highligh= ting of > +identifiers based on their names. Each identifier gets a color based on= a hash > +of its name.") > + (license license:bsd-3))) If I read it correctly, this is FreeBSD license (i.e., 'license:bsd-2'): . --=20 Alex