From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] lint: 'inputs-should-be-native' checks for intltool, itstool and glib:bin.
Date: Sun, 24 Jul 2016 19:57:29 +0200 [thread overview]
Message-ID: <871t2ic41i.fsf@gnu.org> (raw)
In-Reply-To: <20160722175054.6719-1-david@craven.ch> (David Craven's message of "Fri, 22 Jul 2016 19:50:54 +0200")
David Craven <david@craven.ch> skribis:
> * guix/scripts/lint.scm (check-inputs-should-be-native): Warn when intltool,
> itstool or glib:bin isn't a native-input.
> * tests/lint.scm (inputs: glib:bin is probably a native input): Add test.
Neat!
[...]
> + (((labels packages . outputs) ...)
> + (for-each (lambda (package output)
> + (when (package? package)
> + (let ((input (string-append
> + (package-name package)
> + (if (> (length output) 0)
> + (string-append ":" (car output)) ""))))
Identation was misleading, so I’ve fixed that.
> + (when (member input native-inputs)
> + (emit-warning package
> + (string-append input " should probably be a native input"))))))
Here ‘package’ was referring to the input rather than to the package
being linted, so I’ve fixed that; I also switched to ‘format’ and made
sure the string is internationalized.
Pushed as 99fe215cc1c511a82e326727c6a0d193d246a387, thank you!
Ludo’.
prev parent reply other threads:[~2016-07-24 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 17:50 [PATCH] lint: 'inputs-should-be-native' checks for intltool, itstool and glib:bin David Craven
2016-07-24 17:57 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t2ic41i.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).