From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: bug#20067: [PATCH] system: grub: Introduce foreign-menu-entry. Date: Wed, 03 Aug 2016 22:38:24 -0700 Message-ID: <871t25jdpr.fsf@gmail.com> References: <20160803064249.7433-1-sleep_walker@gnu.org> <87lh0d23sf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVBMY-0005dS-Fw for guix-devel@gnu.org; Thu, 04 Aug 2016 01:38:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVBMW-0004QI-1l for guix-devel@gnu.org; Thu, 04 Aug 2016 01:38:33 -0400 In-Reply-To: <87lh0d23sf.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 03 Aug 2016 18:52:32 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org, 20067@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > I still think that the approach proposed at > is more > appropriate; =E2=80=98menu-entry=E2=80=99 would always work, no duplicati= on would be > necessary. > > As a stop-gap measure, I would prefer to (1) allow: > > (menu-entry > ;; =E2=80=A6 > (linux #~(string-append #$kernel "/bzImage"))) > > (2) remove the =E2=80=9C/bzImage=E2=80=9D assumption and use the above id= iom everywhere > in the current code, and (3) and have a hack along these lines to > correctly interpret (string-append =E2=80=A6) in the =E2=80=98parameters= =E2=80=99 file: > > > diff --git a/gnu/system.scm b/gnu/system.scm > index d6bf6c4..467d907 100644 > --- a/gnu/system.scm > +++ b/gnu/system.scm > @@ -766,7 +766,11 @@ this file is the reconstruction of GRUB menu entries= for old configurations." > (boot-parameters > (label label) > (root-device root) > - (kernel linux) > + (kernel (match linux > + (('string-append (? string? strings) ...) > + (string-concatenate strings)) > + (_ > + linux))) > (kernel-arguments > (match (assq 'kernel-arguments rest) > ((_ args) args) > > > Thoughts? Yes, that approach seems better to me. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXotTSAAoJEN1AmhXYIkadC84QAL9STzb7OuiCCZQJobm8I64q qyuVUHGlVuqwD9jNYiMezV1GVxGL3AyUxxH/wFh68nU5+f9598d8ZkKgoHrWw3G9 qOL9wjUtT9wDLFsBk9R+wTc/zy1T7+abG0XcUaLnlZEqgZ/41C41qr4nsm7SVl+K k7AH6clonaq0a/2F5yNzxz+eIwaaBnG5m1/BN88RvuZxgv1IDoiDytUFtB0EuLTI S6+dETGZvefsJigUVhhKbacrrckfbnFP/odbSc68NsCWfQPeMwc4N+Ce5Uwb6xPs OdB67cFVwuf6/P0BcBbalQaXVNQgdyqL2Qpgk1cV3SEYOQbh14HhPXiUDVEmTLBt WFcVmnV4lTu8KvKQIQmHiHWr/g1C9QXCZH+KRNKAFVp/8BJAnaQ/kkuseaxpS6E0 70DPIgY7KMEtq9AqMLlwZi8aoLYFS1t/Y9oMDXtv9hWVBp8kolNYlaFE+Bxi0Fjw RY/ymn8Tm0XaSRnGJIufi8/KqBWoOw5oYyKC0wx3ePuwBS5Cceum2iTM5lXIwmHX FtwxT5DV3kNx9bj/L7JCYAZAsyUJMm/FT9f95xUqHAZlbStjzOrxOZNKE3oPMqh0 14YJ7J5qIgqpCP6udFq0cW02laxdYrauNGe8656009utuUrfDWsReyFGPjyiap8L SMiVLyJ1cPNjmxhK0P/8 =zEv7 -----END PGP SIGNATURE----- --=-=-=--