From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: [PATCH] gnu: Add sg3_utils. Date: Sat, 13 Aug 2016 20:23:38 -0700 Message-ID: <871t1skp8l.fsf@gmail.com> References: <87fuq9xawl.fsf@gmail.com> <87bn0xxafb.fsf@gmail.com> <20160814012743.GB17421@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYm1e-0000rE-2R for guix-devel@gnu.org; Sat, 13 Aug 2016 23:23:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYm1a-0007fH-8l for guix-devel@gnu.org; Sat, 13 Aug 2016 23:23:49 -0400 Received: from mail-pa0-x241.google.com ([2607:f8b0:400e:c03::241]:36272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYm1Z-0007f5-TY for guix-devel@gnu.org; Sat, 13 Aug 2016 23:23:46 -0400 Received: by mail-pa0-x241.google.com with SMTP id ez1so1626493pab.3 for ; Sat, 13 Aug 2016 20:23:45 -0700 (PDT) In-Reply-To: <20160814012743.GB17421@jasmine> (Leo Famulari's message of "Sat, 13 Aug 2016 21:27:43 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > Thanks for this patch! How about putting it in disk.scm? I have no > strong preference either way. I don't like moving things around too much > once they have been created, however :) sg3_utils and its library can be used with any SCSI device, which includes many devices which are not hard disks, such as CD-ROMs and media changers (i.e., jukeboxes), so I don't think it makes sense to put it into a file whose scope is limited to disks. >> + #:use-module ((guix licenses) >> + #:select (gpl2+ bsd-3)) > > Do we need to use #:select here? How about using a license prefix? What > are the pros and cons? > >> +(define-public sg3_utils >> + (package >> + (name "sg3_utils") > > We like to use underscores instead of hyphens in package names: > > https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html#Pa= ckage-Naming Thank you for pointing this out. I've updated it (see attached patch). >> + (description >> + "sg3_utils is a collection of utilities for devices that use the S= mall >> +Computer System Interface (SCSI) command set. It includes utilities to= read >> +data from, write data to, control, modify, and query the state of SCSI >> +devices. For example, this package provides command-line tools to copy= data >> +based on \"dd\" syntax and semantics (called sg_dd, sgp_dd and sgm_dd),= check >> +INQUIRY data and VPD pages (sg_inq), check mode and log pages (sginfo, >> +sg_modes and sg_logs), spin up and down disks (sg_start), do self >> +tests (sg_senddiag), parse sense data, and perform various other functi= ons. >> +In addition, this package includes a library, called libsgutils, which = can be >> +used in C and C++ programs to interact with SCSI devices.") > > I think that dd, and all the sg_* commands, should be wrapped in texinfo > markup, like this: > > @code{dd} Done! Thanks for the tip. =2D-=20 Chris --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-Add-sg3_utils.patch Content-Transfer-Encoding: quoted-printable From=203539ae43993d2118e101446086e123651a132460 Mon Sep 17 00:00:00 2001 From: Chris Marusich Date: Sat, 13 Aug 2016 01:58:03 -0700 Subject: [PATCH] gnu: Add sg3_utils. * gnu/local.mk: Include gnu/packages/scsi.scm. * gnu/packages/scsi.scm: Add new file. * gnu/packages/scsi.scm (sg3_utils): New variable. =2D-- gnu/local.mk | 1 + gnu/packages/scsi.scm | 54 +++++++++++++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 55 insertions(+) create mode 100644 gnu/packages/scsi.scm diff --git a/gnu/local.mk b/gnu/local.mk index 44ace61..99dbb30 100644 =2D-- a/gnu/local.mk +++ b/gnu/local.mk @@ -305,6 +305,7 @@ GNU_SYSTEM_MODULES =3D \ %D%/packages/scheme.scm \ %D%/packages/screen.scm \ %D%/packages/scribus.scm \ + %D%/packages/scsi.scm \ %D%/packages/sdl.scm \ %D%/packages/search.scm \ %D%/packages/serialization.scm \ diff --git a/gnu/packages/scsi.scm b/gnu/packages/scsi.scm new file mode 100644 index 0000000..92e2d7a =2D-- /dev/null +++ b/gnu/packages/scsi.scm @@ -0,0 +1,54 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2016 Chris Marusich +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu packages scsi) + #:use-module ((guix licenses) + #:select (gpl2+ bsd-3)) + #:use-module (guix packages) + #:use-module (guix download) + #:use-module (guix build-system gnu)) + +(define-public sg3-utils + (package + (name "sg3-utils") + (version "1.42") + (source (origin + (method url-fetch) + (uri (string-append "http://sg.danny.cz/sg/p/sg3_utils-" + version ".tar.xz")) + (sha256 + (base32 + "1fg71rj0f1gdjmkj0z8wlv46cf9lryjdyjkbi7fjmssgi5jyvblp")))) + (build-system gnu-build-system) + (home-page "http://sg.danny.cz/sg/sg3_utils.html") + (synopsis "SCSI device utilities") + (description + "sg3-utils is a collection of utilities for devices that use the Small +Computer System Interface (SCSI) command set. It includes utilities to re= ad +data from, write data to, control, modify, and query the state of SCSI +devices. For example, this package provides command-line tools to copy da= ta +based on @code{dd} syntax and semantics (called @code{sg_dd}, @code{sgp_dd} +and @code{sgm_dd}), check INQUIRY data and VPD pages (@code{sg_inq}), check +mode and log pages (@code{sginfo}, @code{sg_modes} and @code{sg_logs}), sp= in +up and down disks (@code{sg_start}), do self tests (@code{sg_senddiag}), p= arse +sense data (@code{sg_decode_sense}), and perform various other functions. = In +addition, this package includes a library, called libsgutils, which can be +used in C and C++ programs to interact with SCSI devices.") + ;; The libsgutils library itself is licensed under bsd-3. Some tools = are + ;; licensed under bsd-3, also. Some tools are licensed under gpl2+. + (license (list gpl2+ bsd-3)))) =2D-=20 2.9.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXr+Q8AAoJEN1AmhXYIkadaaYP/Ap9SrV5GG4MrmFyFxCBGZ4b GXaYI8za40CGx4aKbAeVTr092FI+lOsn+/a4/I2E5twArv1a1tA7uy1xuPh2iF2A 2I3igpoX6CpRoKOUrI2v8LaMRNQoIqJME9Ufwp1067lBVYLhKLH4nzyfdlJrlDtI C+YSSc5G/QdWyWBgYwvfUAKhsOvrXK8r4VsZSUdXOE5U352g8A2qd9DjOK8bUm9Y 71lTaJS/HfcB04lg95FbWnqZzacyplyJ0qzb0EYmyNY9Ck0uZwKY9Y8xa2887dGJ LFWHyOQax+HjQe9kEWTJPX8dbLR+QVSYC+sKvoDOtYGE92rhZyTbH6h+IyDhVzaw BBU0aYq02z0pmKz8D8Fvm7ZDVgPi3fF1fnCvaEww8M/uMWD5bLJEzO2N8GxFAwwg IEaWb5K40fLWh2CAukonIMnyqSWB5X7qpAxVx5B0NTSyraXyMYh0edHq/THTFvaT SYSBItLiC3kxiYxdmbzELXvN51jnNu5cilZ7smqVqot71O78AAsOM37vadaArdjL NpFxQTtcLySHF5Za9kuiv5NR6cZEbkkQvPgxAw9uKVQjPKkIi/iWBhh1uu0KJ/X8 hSgPNPxEjRCzFQO+dGC1cvUlG9qi+R55NgoQ3wnu62kUxfz8Uxx0I2CBpMNlgGEX i0sz9bTZTnuciGbLQvyw =dWtd -----END PGP SIGNATURE----- --==-=-=--