From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add coda.
Date: Wed, 19 Oct 2016 22:13:42 +0200
Message-ID: <871szc5c7d.fsf@gnu.org>
References: <20161019.115909.841864783716767477.post@thomasdanckaert.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46737)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bwxFK-0001Pa-1M
	for guix-devel@gnu.org; Wed, 19 Oct 2016 16:13:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bwxFG-00049E-Qv
	for guix-devel@gnu.org; Wed, 19 Oct 2016 16:13:54 -0400
In-Reply-To: <20161019.115909.841864783716767477.post@thomasdanckaert.be>
	(Thomas Danckaert's message of "Wed, 19 Oct 2016 11:59:09 +0200
	(CEST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: guix-devel@gnu.org

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> This is a C library wich also presents a python interface.  It can be
> used just as well without python, so I've made python only a native
> input, not a regular input.  There's currently a non-determinism issue
> for the python interface, related to
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22533
>
> I also tried to automatically generate the string
> =E2=80=9Clib/python3.4/site-packages=E2=80=9D, so it's updated automatica=
lly when the
> python version changes, but didn't manage to do that (for example I
> tried
>
>   (version-major+minor (package-version python))
>
> but the package variable =E2=80=9Cpython=E2=80=9D is not available when t=
he build
> expression is turned into a derivation, as far as I understand
> it?). Advice welcome.

I think this is not needed; see below.

> From edb38dfcc09afdef4279728c84d10688b9d0fc71 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Wed, 19 Oct 2016 11:44:33 +0200
> Subject: [PATCH] gnu: Add coda.
>
> * gnu/packages/maths.scm (coda): New variable.

[...]

> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "PYTHONPATH")
> +            (files '("lib/python3.4/site-packages")))))

Unless I=E2=80=99m mistaken this is not needed: this =E2=80=98native-search=
-paths=E2=80=99 entry
belongs in Python itself, not in users of Python.

> +    (synopsis "Common interface to various earth observation data format=
s")
> +    (description
> +     "The Common Data Access toolbox (CODA) provides a set of interfaces=
 for
> +reading remote sensing data from earth observation data files.  These
> +interfaces consist of command line applications, libraries, interfaces to
> +scientific applications (such as IDL and MATLAB), and interfaces to

Let=E2=80=99s remove MATLAB; we can replace it with Octave if it=E2=80=99s =
valid.

> +    (license license:gpl2)))

Version 2 only?  That is, is the =E2=80=9Cor any later version=E2=80=9D wor=
ding missing
from license headers?

Otherwise LGTM.

Could you send an updated patch?

Thank you!

Ludo=E2=80=99.