From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Add system roll-back and switch-generation commands Date: Sat, 29 Oct 2016 23:13:45 +0200 Message-ID: <871syyvoxi.fsf@gnu.org> References: <20161028100727.1182-1-cmmarusich@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0awo-00053X-Sp for guix-devel@gnu.org; Sat, 29 Oct 2016 17:13:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0awl-0004VR-Oe for guix-devel@gnu.org; Sat, 29 Oct 2016 17:13:50 -0400 In-Reply-To: <20161028100727.1182-1-cmmarusich@gmail.com> (cmmarusich@gmail.com's message of "Fri, 28 Oct 2016 03:07:17 -0700") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: cmmarusich@gmail.com Cc: guix-devel@gnu.org Hi Chris! cmmarusich@gmail.com skribis: > This patch series adds 'guix system roll-back' and 'guix system > switch-generation' commands. It should apply cleanly to the current mast= er > branch. Cool, I=E2=80=99ll start looking. > I've tested the patches manually on a VM with a single disk, and a VM with > multiple disks (with the store on a separate disk). Two of the "check-sy= stem" > tests fail (nss-mdns and encrypted-root-os), but those are failing on the > current master branch for me anyway, and I can't recall ever seeing them = pass, > so I have no reason to suspect that my changes are causing the failures. Great that you took the time to test thoroughly. =E2=80=98nss-mdns=E2=80=99 passes, but intermittently fails in my experienc= e, but it=E2=80=99s a tough problem. =E2=80=98encrypted-root-os=E2=80=99 was committed by mistake and the code t= o make it pass has not been committed yet. :-) Of all the system tests, only the 3 in (gnu tests install) really test the =E2=80=98guix system=E2=80=99 command, which is what we=E2=80=99re inte= rested in here. Ludo=E2=80=99.