From: Marius Bakke <mbakke@fastmail.com>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] mps-youtube
Date: Wed, 02 Nov 2016 14:20:42 +0000 [thread overview]
Message-ID: <871syuarph.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87twbqgf80.fsf@we.make.ritual.n0.is>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
ng0 <ng0@we.make.ritual.n0.is> writes:
>>> So far they are in (inputs). Are those supposed to be installed by the users themselves?
>>
>> For optional dependencies (i.e. if mps-youtube gracefully handles
>> missing ffmpeg), leaving it up to the user is good (but then it should
>> not be an input). For "hard" runtime dependencies, the absolute paths
>> must be recorded so that they won't get garbage collected.
>>
>
> With the info I gave above, I'd say I remove the dependencies
> which are not found and add information to the description.
> For example: … it can be used with either mpv or mplayer, for
> optional format conversion you need to use ffmpeg.
>
> What do you think?
That sounds sensible. It seems to handle the case where those are
missing as well, which is good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]
next prev parent reply other threads:[~2016-11-02 14:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 10:40 [PATCH] mps-youtube ng0
2016-11-02 10:40 ` [PATCH 1/2] gnu: Add python-pafy ng0
2016-11-02 17:27 ` Hartmut Goebel
2016-11-04 18:18 ` ng0
2016-11-04 18:41 ` Hartmut Goebel
2016-11-04 18:52 ` ng0
2016-11-04 19:23 ` [PATCH] mps-youtube, revision 3 ng0
2016-11-04 19:23 ` [PATCH 1/2] gnu: Add python-pafy ng0
2016-11-04 19:23 ` [PATCH 2/2] gnu: Add mps-youtube ng0
2016-11-04 19:42 ` [PATCH] mps-youtube, revision 3 Hartmut Goebel
2016-11-05 12:33 ` Marius Bakke
2016-11-05 12:49 ` ng0
2016-11-02 10:40 ` [PATCH 2/2] gnu: Add mps-youtube ng0
2016-11-02 12:34 ` [PATCH] mps-youtube Marius Bakke
2016-11-02 13:53 ` ng0
2016-11-02 14:20 ` Marius Bakke [this message]
2016-11-02 14:24 ` [PATCH] mps-youtube, revision 2 ng0
2016-11-02 14:24 ` [PATCH 1/2] gnu: Add python-pafy ng0
2016-11-02 14:24 ` [PATCH 2/2] gnu: Add mps-youtube ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871syuarph.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).