From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: libreoffice: Add 'libreoffice' symlink. Date: Thu, 08 Dec 2016 12:37:53 +0300 Message-ID: <871sxidamm.fsf@gmail.com> References: <20161206195241.23575-1-ng0@libertad.pw> <20161206200444.24200-1-ng0@libertad.pw> <20161206200444.24200-2-ng0@libertad.pw> <87wpfcssn8.fsf@gmail.com> <8760mw6b8j.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEvAH-0006oQ-Ul for guix-devel@gnu.org; Thu, 08 Dec 2016 04:38:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEvAE-0005ko-PX for guix-devel@gnu.org; Thu, 08 Dec 2016 04:38:58 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33115) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cEvAE-0005k2-JO for guix-devel@gnu.org; Thu, 08 Dec 2016 04:38:54 -0500 Received: by mail-wm0-f65.google.com with SMTP id u144so2351347wmu.0 for ; Thu, 08 Dec 2016 01:38:54 -0800 (PST) In-Reply-To: <8760mw6b8j.fsf@we.make.ritual.n0.is> (ng0@libertad.pw's message of "Tue, 06 Dec 2016 20:42:04 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org ng0 (2016-12-06 20:42 +0000) wrote: > Alex Kost writes: [...] >> I've just noticed that there is 'bin-install' phase right before it, so >> I think an additional phase is not needed at all, the required >> symlinking can be done in that 'bin-install' phase. > > Okay, I did not want to touch that because I did think for some > reason it should be separated, but what you provided as diff > further below looks better than my approach. I'd be okay with > this. My change is so small, you could probably create your own > patch and send it to this thread. Since it's trivial, I committed it=C2=B9... but then I realized that originally it was more like a question about adding 'libreoffice' link along with the 'soffice' one. So I hope other people will not object that there is 'bin/libreoffice' now :-) =C2=B9 http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3Dcb72d34348998= 501c0dfa9f6ac4eb64bddd99fbf --=20 Alex