From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 1/2] gnu: Add r-bit. Date: Tue, 13 Dec 2016 17:30:52 +0100 Message-ID: <871sxbdc5f.fsf@elephly.net> References: <20161213100008.19640-1-donttrustben@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGpzD-0004C3-7Z for guix-devel@gnu.org; Tue, 13 Dec 2016 11:31:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGpz8-0004v3-MA for guix-devel@gnu.org; Tue, 13 Dec 2016 11:31:27 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:21439) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGpz8-0004u9-Dn for guix-devel@gnu.org; Tue, 13 Dec 2016 11:31:22 -0500 In-reply-to: <20161213100008.19640-1-donttrustben@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel@gnu.org Hi Ben, thanks for the patch! > * gnu/packages/statistics.scm (r-bit): New variable. > --- > gnu/packages/statistics.scm | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm > index 36f1889ef..ea9ef0e39 100644 > --- a/gnu/packages/statistics.scm > +++ b/gnu/packages/statistics.scm > @@ -205,6 +205,29 @@ publication-quality data plots. A large amount of 3rd-party packages are > available, greatly increasing its breadth and scope.") > (license license:gpl3+))) > > +(define-public r-bit > + (package > + (name "r-bit") > + (version "1.1-12") > + (source > + (origin > + (method url-fetch) > + (uri (cran-uri "bit" version)) > + (sha256 > + (base32 > + "0a6ig6nnjzq80r2ll4hc74za3xwzbzig6wlyb4dby0knzf3iqa6f")))) > + (build-system r-build-system) > + (home-page "http://ff.r-forge.r-project.org") > + (synopsis "A class for vectors of 1-bit booleans") Without “A” please. Just “Class for vectors …”. > + (description > + "This package provides bitmapped vectors of booleans (no NAs), coercion > +from and to logicals, integers and integer subscripts; fast boolean operators > +and fast summary statistics. With 'bit' vectors true binary booleans “With *the @code{bit} class* vectors *of* true binary booleans …” > +{FALSE,TRUE} can be stored with 1 bit only, on a 32 bit architecture this > +means factor of 32 less RAM and a factor of 32 more speed on boolean > +operations.") I’d leave off “, on a 32 bit architecure …”. If you want to keep it, though, I’d suggest making this a separate full sentence (or at least separate them with a semicolon). > + (license license:gpl2))) > + > (define-public r-colorspace > (package > (name "r-colorspace") Pity it’s GPL2 only, but this seems to be correct (there are even license headers with an explicit version). Okay with these changes. Thanks! -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC http://elephly.net