From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 6/6] gnu: Add grub-efi. Date: Fri, 16 Dec 2016 18:09:35 +0100 Message-ID: <871sx73ink.fsf@gnu.org> References: <20161105125511.29383-1-mbakke@fastmail.com> <20161105125511.29383-7-mbakke@fastmail.com> <20161105185803.GA11667@jasmine> <87h97l67kz.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <878tsww9ov.fsf@gnu.org> <87vaw087kr.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <871syny88o.fsf@gnu.org> <87oa1r8wyv.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHw0r-000715-HT for guix-devel@gnu.org; Fri, 16 Dec 2016 12:09:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHw0o-0001Yq-9T for guix-devel@gnu.org; Fri, 16 Dec 2016 12:09:41 -0500 In-Reply-To: <87oa1r8wyv.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Mon, 07 Nov 2016 09:23:36 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Hi Marius, Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >>>>> From 940c03c7dcddec019e27f6eb1470aeab4db57799 Mon Sep 17 00:00:00 2001 >>>>> From: Marius Bakke >>>>> Date: Thu, 20 Oct 2016 17:26:52 +0100 >>>>> Subject: [PATCH] gnu: Add grub-efi. >>>>> >>>>> * gnu/packages/grub.scm (grub-efi): New variable. >>>> >>>> [...] >>>> >>>>> + (name "grub-efi") >>>>> + (synopsis (string-append (package-synopsis grub) " (UEFI version= )")) >>>> >>>> Please use a literal string for =E2=80=98synopsis=E2=80=99; use of =E2= =80=98string-append=E2=80=99 like >>>> this prevents i18n. >>>> >>>>> + `(#:tests? #f ; FIXME: 40 failures, 24 skipped, 17 passed. >>>> >>>> It would be good to investigate, especially if the tests pass in the >>>> =E2=80=98grub=E2=80=99 package. >>>> >>>> Also, what=E2=80=99s the rationale for making =E2=80=98grub-efi=E2=80= =99 separate instead of >>>> incorporating the changes in =E2=80=98grub=E2=80=99 proper? Are there= issues around the >>>> portability of =E2=80=98efibootmgr=E2=80=99, or an increased closure s= ize? >>> >>> This is a good point. The only difference with "--with-platform=3Defi" = is >>> that another directory is created in place of the i386-pc directory. It >>> is perfectly possible to build multiple platforms and copying the >>> platform-specific stuff to $out/lib -- grub will pick the correct >>> platform at runtime. This is what the Gentoo ebuild does. >> >> Are you saying that a GRUB compiled with UEFI support will no longer >> work out-of-the-box on non-UEFI machines, unless platform-specific stuff >> is moved like you suggest? > > Ha, no, it was just a long-winded and intoxicated way of saying what you > proposed should work fine. :) It turns out I have an immediate need ;-), so I pushed this as commit 3eee16130d858ae96510ec1c7d38d31290de2699. Let me know if that doesn=E2=80= =99t seem right! Now there are things I didn=E2=80=99t quite get. Apparently you=E2=80=99re= supposed to have a /boot/efi as a vfat partition, and =E2=80=98grub-install=E2=80=99 is= supposed to detect it and install the EFI stuff, or so I thought (info "(grub) Installing GRUB using grub-install"). However, =E2=80=98grub-install=E2=80=99 still seems to be installing for = =E2=80=9Ci386-pc=E2=80=9D instead of EFI. What am I missing? Thanks! Ludo=E2=80=99.