Re: [PATCH 02/10] gnu: Add propeller-binutils.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <rekado@elephly.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:

[...]

>>> +      (native-inputs
>>> +       `(("bison" ,bison)
>>> +         ("flex" ,flex)
>>> +         ("texinfo" ,texinfo)
>>> +         ("dejagnu" ,dejagnu)
>>
>> The test failures you see are because you added DejaGNU here.  The other
>> Binutils instances don’t have it, so few tests are run I guess.  :-)
>>
>> If this is not needed for bootstrapping, I’d suggest removing it.
>
> I added DejaGNU because it provides “runtest”, which is needed by the
> tests.  Without DejaGNU the check phase fails trying to execute
> “runtest”.

I wonder why this is an error here.  The behavior in vanilla Binutils is
to simply warn about the lack of ‘runtest’ (which is why it doesn’t have
#:tests? #f):

--8<---------------cut here---------------start------------->8---
srcdir=`cd . && pwd`; export srcdir; \
r=`pwd`; export r; \
LC_ALL=C; export LC_ALL; \
EXPECT=expect; export EXPECT; \
runtest=runtest; \
if /gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/bash -c "$runtest --version" > /dev/null 2>&1; then \
  CC="gcc" CC_FOR_BUILD="gcc" \
  CC_FOR_TARGET="gcc" CFLAGS_FOR_TARGET="-g -O2" \
	$runtest --tool binutils --srcdir ${srcdir}/testsuite \
		; \
else echo "WARNING: could not find \`runtest'" 1>&2; :;\
fi
WARNING: could not find `runtest'
make[5]: Leaving directory '/tmp/nix-build-binutils-2.27.drv-0/binutils-2.27/binutils'
--8<---------------cut here---------------end--------------->8---

(From <https://mirror.hydra.gnu.org/log/xv32q9gbrvkyg01y0pj7m4clh6k29n15-binutils-2.27>.)

Ludo’.