From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: librsvg & Rust Date: Sat, 23 Mar 2019 23:44:11 +0100 Message-ID: <871s2x1a9w.fsf@fastmail.com> References: <20190220161027.17460.87383@vcs0.savannah.gnu.org> <20190220161038.3F54B2040C@vcs0.savannah.gnu.org> <87bm2ol0ud.fsf_-_@gnu.org> <875zswngzb.fsf@fastmail.com> <87y35g5qag.fsf@gnu.org> <877ed09s0a.fsf@fastmail.com> <87h8btwn0t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:52289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7pNB-00010g-5d for guix-devel@gnu.org; Sat, 23 Mar 2019 18:44:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7pNA-0005DQ-3Q for guix-devel@gnu.org; Sat, 23 Mar 2019 18:44:17 -0400 In-Reply-To: <87h8btwn0t.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Marius Bakke skribis: > >> Ludovic Court=C3=A8s writes: > > [...] > >>>> I wanted to ask about this: is Rust supported on all the platforms we >>>> support at the moment? >>> >>> According to Efraim and Danny, we have a problem at the moment. >>> Presumably that can be worked around? >> >> Right, Rust currently only works on x86_64. In order to get this branch >> started, let us either: >> >> * Revert back to 2.40.20, or >> * Conditionally use the new version on supported platforms >> >> For the latter, I imagine something along the lines of... >> >> (define-public librsvg >> (if (string-prefix? "x86_64" (or (%current-target-system) >> (%current-system))) >> librsvg-2.44 >> librsvg-2.40)) > > It would have to be a macro so that the conditional is evaluated in a > context where (%current-system) and (%current-target-system) have the > right value, like the =E2=80=98glibc=E2=80=99 macro we had until commit > 2d546858b139e5fcf2cbdf9958a17fd98803ac4c. Right, thanks! >> Preferences? > > I have a slight preference for having the same librsvg on all platforms. > > So we could add 2.44 alongside 2.40, but keep using 2.40 until our Rust > package works on all the platforms. > > That said, if the chances are that Rust won=E2=80=99t work on all 4 platf= orms in > the foreseeable future, the other option (upgrading on platforms where > Rust is supported) may be preferable. > > Your call! :-) I don't have a strong opinion, so I restored the previous librsvg variant for now and kept the Rust one as 'librsvg-next' with commit f67417a1b4d3fbd3a2e1593d32422e0d901ba367. Let's "freeze" and try to merge this branch soon. Are there any pending patches? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlyWtrsACgkQoqBt8qM6 VPqaRQf+KTPobOQnwhnFDkjVTr1rM/NVnXfVHGEgA+jRcgE20Qs/x5n4vkAf58L1 a+f1tJThQE2jx2QUu6mVKSCybf70Ulp/9ohI+H8821YLEkY7sAi4jEu27/EtHPDs nhcY92HRpQIglYdW78rD1xKSMBex3byUojbx9DQlT3SsAFexYZUrFoGu8x7bm5U6 hgmKPTxUEVGQGTqBUf/BZOWsw9jz5BGKfKng8aeagcrZxCmZYeduMFju94YDPUHv 5Lp3r9S08kIn9CSGQre2ZmEfIzaOislS92dPedTDFONXd9Y4OOYVURqllPDhiiiv 5CFXQdQw+an7ZvrDsQsGFpmBKgNfyA== =0xFJ -----END PGP SIGNATURE----- --=-=-=--