unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: mike.rosset@gmail.com
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org, GNU Guix maintainers <guix-maintainers@gnu.org>
Subject: Re: qtwenengine anybody?
Date: Mon, 06 Jan 2020 16:27:43 -0800	[thread overview]
Message-ID: <871rsccdq8.fsf@gmail.com> (raw)
In-Reply-To: <87d0bw2xtj.fsf@devup.no> (Marius Bakke's message of "Mon, 06 Jan 2020 20:23:52 +0100")

Marius Bakke <mbakke@fastmail.com> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Hi Mike,
>>
>> thank you for your patient reply.
>>
>>> Ricardo Wurmus <rekado@elephly.net> writes:
>>>
>>>> Does the code include DRM support, for example?  Does it phone home?
>>>> Can we see the patches that upstream applied to the Chromium sources?
>>>>
>>>
>>> QtWebengine does not handle DRM at all. That is handled by a 3rd party
>>> plugin called wildevine and would require guix to bundle that plugin.
>>> Something I'm confident is not going to happen. As an added measure my
>>> proposed qtwebengine declaration has pepper plugins disabled making it
>>> impossible to load 3rd party plugins either way.
>>>
>>> see https://doc.qt.io/qt-5/qtwebengine-features.html#html5-drm
>>> for reference
>>
>> I’m aware of this.  My apologies for not expressing myself more
>> clearly.  We probably want to remove the support for the DRM plugin,
>> following the discussions about ungoogled-chromium at
>>
>>     https://issues.guix.gnu.org/issue/34565
>
> I have attached a patch that disables support for loading the Widevine
> plugin, and also removes unused bundled software from the source based
> on a whitelist, similar to ungoogled-chromium's
> %PRESERVED-THIRD-PARTY-FILES.
>
> It removes some 300+ MiB from the uncompressed sources.  The snippet
> will require some adjustments for every new version of QtWebEngine
> however, I can help out with that when required.
>
> Patch 1/2 is a slightly "cleaned up" version of Mike's latest patch,
> fixing some cosmetic issues, and makes it respect the daemons requested
> number of build cores.
>
> With these changes, I think the package is ready to go.  \o/

This is really great work Marius I appreciate this addition. I was
actually just looking at this approach yesterday. 

I've merged your two patches with one minor description addition that Hartmut
requested.

Hartmut the merged complete diff can be found here.

https://gitlab.com/mike.rosset/guix/compare/master...merge-qtwebengine

 
Mike 

  reply	other threads:[~2020-01-07  0:27 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 12:55 qtwenengine anybody? Hartmut Goebel
2019-12-16 13:42 ` Pierre Neidhardt
2019-12-16 14:13   ` mike.rosset
2019-12-16 14:15     ` Pierre Neidhardt
2019-12-16 15:19       ` mike.rosset
2019-12-16 15:22     ` Hartmut Goebel
2019-12-16 15:45       ` mike.rosset
2019-12-16 15:57         ` Hartmut Goebel
2019-12-16 17:09           ` mike.rosset
2019-12-16 17:29             ` Hartmut Goebel
2019-12-18 21:24               ` mike.rosset
2019-12-18 22:03                 ` Pierre Neidhardt
2019-12-18 22:30                   ` mike.rosset
2019-12-19 18:23                     ` Pierre Neidhardt
2019-12-19 19:47                       ` mike.rosset
2019-12-19 20:36                         ` Pierre Neidhardt
2019-12-20  0:16                           ` mike.rosset
2019-12-20 10:46                             ` Pierre Neidhardt
2019-12-20 10:53                               ` Pierre Neidhardt
2019-12-18 22:46                 ` Ricardo Wurmus
2019-12-20 10:49                 ` Pierre Neidhardt
2019-12-20 16:04                   ` mike.rosset
2019-12-20 16:16                     ` Pierre Neidhardt
2019-12-20 16:44                       ` mike.rosset
2019-12-31 13:48                         ` Pierre Neidhardt
2019-12-31 13:50                           ` Pierre Neidhardt
2020-01-01 17:34                             ` mike.rosset
2020-01-01 20:43                               ` Pierre Neidhardt
2020-01-01 22:30                                 ` mike.rosset
2020-01-02 12:29                                   ` Hartmut Goebel
2020-01-02 20:24                                     ` mike.rosset
2020-01-03 14:57                                       ` Hartmut Goebel
2020-01-05 16:10                                         ` mike.rosset
2020-01-05 16:47                                           ` Hartmut Goebel
2020-01-01 22:46                                 ` Ricardo Wurmus
2020-01-02 10:52                                   ` Pierre Neidhardt
2020-01-05 14:59                                   ` mike.rosset
2020-01-05 19:52                                     ` Ricardo Wurmus
2020-01-06  5:11                                       ` mike.rosset
2020-01-06 19:23                                       ` Marius Bakke
2020-01-07  0:27                                         ` mike.rosset [this message]
2020-01-07 10:26                                           ` Hartmut Goebel
2020-01-07 19:28                                             ` mike.rosset
2020-01-11 17:39                                               ` Marius Bakke
2020-01-11 17:40                                                 ` Pierre Neidhardt
2020-01-11 18:19                                                   ` Mike Rosset
2020-01-11 18:28                                                     ` Pierre Neidhardt
2020-01-13 10:54                                                   ` Mike Rosset
2020-01-13 14:26                                                     ` Pierre Neidhardt
2020-01-13 18:37                                                       ` Mike Rosset
2020-01-11 18:14                                                 ` Mike Rosset
2020-01-07  8:09                                         ` Pierre Neidhardt
2020-01-07 19:14                                           ` mike.rosset
2020-01-07  8:12                                         ` Pierre Neidhardt
2020-01-07 22:49                                           ` Marius Bakke
2020-01-01 17:22                           ` mike.rosset

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rsccdq8.fsf@gmail.com \
    --to=mike.rosset@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=guix-maintainers@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).