From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kP/lG7c6zF5xbwAA0tVLHw (envelope-from ) for ; Mon, 25 May 2020 21:37:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GNPeF7c6zF6TLwAA1q6Kng (envelope-from ) for ; Mon, 25 May 2020 21:37:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F71F940390 for ; Mon, 25 May 2020 21:37:59 +0000 (UTC) Received: from localhost ([::1]:46104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdKnG-00052r-6w for larch@yhetil.org; Mon, 25 May 2020 17:37:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdKn8-00052h-M7 for guix-devel@gnu.org; Mon, 25 May 2020 17:37:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58052) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdKn8-0001R7-4y; Mon, 25 May 2020 17:37:50 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52416 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jdKmj-0005Lz-Hp; Mon, 25 May 2020 17:37:48 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Vagrant Cascadian Subject: Re: Updating the =?utf-8?B?4oCccHJlLXB1c2jigJ0=?= Git hook References: <87imgn8zsv.fsf@gnu.org> <20200524064115.GC858@E5400> <878shhxb0h.fsf@gnu.org> <87pnar22oz.fsf@yucca> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Prairial an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 25 May 2020 23:37:24 +0200 In-Reply-To: <87pnar22oz.fsf@yucca> (Vagrant Cascadian's message of "Mon, 25 May 2020 13:13:16 -0700") Message-ID: <871rn7snl7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Avru9L70SBUC Hi! Vagrant Cascadian skribis: > On 2020-05-24, Ludovic Court=C3=A8s wrote: >> Efraim Flashner skribis: >>> On Fri, May 22, 2020 at 10:44:48PM +0200, Ludovic Court=C3=A8s wrote: >>>> Hello Guix! >>>>=20 >>>> I think we should change our pre-push hook as shown below. >>>>=20 >>>> Thoughts? > ... >>> (ins)efraim@E5400 ~$ type -P make >>> (ins)efraim@E5400 ~$ command -v make >>> >>> I'd need to run 'guix environment --ad-hoc make -- git push' >> >> You=E2=80=99d need to run =E2=80=98git push=E2=80=99 from a full Guix de= velopment environment. >> Do you think it could be a problem? > > Wait a minute... you're saying this is something that needs to be > configured on each committer's machine(s)? > > Shouldn't it be on the server-side recieve hooks instead, otherwise > someone might accidentally (or intentially) push commits not > appropriately signed to the repository or validated by this check... > > Or is this an optional check for recommended for committers? Have I been > missing something all along that I was supposed to be doing? It should be a server-side check so we don=E2=80=99t shoot ourselves in the= foot. However, it=E2=80=99s not done yet (but hey, the code is not even a month o= ld :-)), so in the meantime, this hook will be very strongly recommended. Making this a server-side hook on Savannah will be challenging since =E2=80=9Cwe=E2=80=9D don=E2=80=99t have direct access to Savannah. That ma= kes me wonder if we should have a push server say on berlin, and make Savannah mirror it or something. Help welcome! > For my own workflow, I usually do not (yet) sign or push commits from a > machine with guix installed... it's a bit awkward, admittedly, but I > don't yet have any SSH or OpenPGP keys I trust guix with directly > (ironically, "make authenticate" is working towards addressing exactly > that trust issue). Heh. :-) Thanks, Ludo=E2=80=99.