unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Zhu Zihao <all_but_last@163.com>
To: Marius Bakke <marius@gnu.org>
Cc: guix-devel@gnu.org, Zhu Zihao <all_but_last@163.com>
Subject: Re: [PATCH] gnu: Add font-sarasa-gothic
Date: Sat, 30 May 2020 23:14:08 +0800	[thread overview]
Message-ID: <871rn1v4jj.wl-all_but_last@163.com> (raw)
In-Reply-To: <877dwtze50.fsf@gnu.org>

You miss the right angle bracket in the copyright line

It should be

;;; Copyright © 2020 Zhu Zihao <all_but_last@163.com>
                                                    ^

Others are OK.

On Sat, 30 May 2020 22:33:15 +0800,
Marius Bakke wrote:
>
> [1  <multipart/mixed (7bit)>]
> [1.1  <text/plain (7bit)>]
> Zhu Zihao <all_but_last@163.com> writes:
>
> > This patch adds Sarasa Gothic. Sarasa Gothic is based on Iosevka and Source Han
> > Sans, intends to make a really monospaced(inclduing CJK characters) programming
> > fonts. In Sarasa Gothic, a normal CJK character is same height and double width
> > as an ASCII character.
>
> Thanks!  Applied with the following changes, hope the copyright line was
> okay:
>
> [1.2 diff <text/x-patch; utf-8 (quoted-printable)>]
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 3c7361f162..f60d4f80fb 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -34,6 +34,7 @@
>  ;;; Copyright © 2020 John Soo <jsoo1@asu.edu>
>  ;;; Copyright © 2020 Raghav Gururajan <raghavgururajan@disroot.org>
>  ;;; Copyright © 2020 Julien Lepiller <julien@lepiller.eu>
> +;;; Copyright © 2020 Zhu Zihao <all_but_last@163.com
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1267,7 +1268,7 @@ programming.  Iosevka is completely generated from its source code.")
>                        (mkdir "source")
>                        (chdir "source")
>                        (invoke "7z" "x" source))))))
> -    (native-inputs `(("p7zip" ,(@ (gnu packages compression) p7zip))))
> +    (native-inputs `(("p7zip" ,p7zip)))
>      (home-page "https://github.com/be5invis/Sarasa-Gothic")
>      (license license:silofl1.1)
>      (synopsis "Sarasa Gothic / 更纱黑体 / 更紗黑體 / 更紗ゴシック / 사라사 고딕")
> [2 signature.asc <application/pgp-signature (7bit)>]
> No public key for A2A06DF2A33A54FA created at 2020-05-30T22:33:15+0800 using RSA



  reply	other threads:[~2020-05-30 15:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29 16:44 [PATCH] gnu: Add font-sarasa-gothic Zhu Zihao
2020-05-30 14:33 ` Marius Bakke
2020-05-30 15:14   ` Zhu Zihao [this message]
2020-05-30 21:24     ` Marius Bakke
  -- strict thread matches above, loose matches on Subject: below --
2020-05-30  2:50 Zhu Zihao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rn1v4jj.wl-all_but_last@163.com \
    --to=all_but_last@163.com \
    --cc=guix-devel@gnu.org \
    --cc=marius@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).