unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: Canonical-packages restoration.
Date: Wed, 10 Jun 2020 17:24:25 +0200	[thread overview]
Message-ID: <871rmndjva.fsf@gnu.org> (raw)
In-Reply-To: <87zh9bmfey.fsf@gnu.org> (Mathieu Othacehe's message of "Wed, 10 Jun 2020 11:35:49 +0200")

Hi,

Mathieu Othacehe <othacehe@gnu.org> skribis:

>> What if, instead, we removed those “canonical” packages entirely from
>> the reference graph?  Do you think that’s an option?
>
> It seems to be a better option! So, as I did remove most of the explicit
> references to 'canonical-packages' the only references left are
> implicit.
>
> A good example is "isc-dhcp", that refers to implicit canonical inputs
> "coreutils" and "sed" in the "dhclient-script". The attached patch fixes
> it. I could do the same for a few other packages and it should fix the
> issue.

Yes, sounds good to me!

> The problem is that approach is not very long-term. Maybe we should take
> a step back. Would it be an option to add all the canonical-packages as
> disallowed-references?

Hmm yes, we could try that, but there’ll probably be many changes to
make.

> Or could we use implicit inputs that are not rooted in the bootstrap
> chain?

The problem is not that they’re rooted in the bootstrap chain (they
necessary build-depend on the bootstrap chain, but they’re guaranteed
not to have references to it).  The problem is that we have two copies
of all these: coreutils-final vs. coreutils, guile-final vs. guile, etc.

As things are, it seems hard to avoid.

>> Bah yes, that’s why initially I didn’t push ‘let-system’:
>>
>>   https://issues.guix.gnu.org/29296#4
>>
>> Perhaps we could avoid the expander = #f special case.
>
> Ok, I will try to fix it then.

No rush though, we can do that anytime.

Thanks,
Ludo’.


      reply	other threads:[~2020-06-10 15:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 10:22 Canonical-packages restoration Mathieu Othacehe
2020-06-09 11:18 ` Jan Nieuwenhuizen
2020-06-09 11:30   ` Mathieu Othacehe
2020-06-09 16:34 ` Ludovic Courtès
2020-06-10  9:35   ` Mathieu Othacehe
2020-06-10 15:24     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rmndjva.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).