From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uFYmAi6cQ1/cBwAA0tVLHw (envelope-from ) for ; Mon, 24 Aug 2020 10:53:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OEqeOS2cQ194EgAA1q6Kng (envelope-from ) for ; Mon, 24 Aug 2020 10:53:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8385F94053D for ; Mon, 24 Aug 2020 10:53:33 +0000 (UTC) Received: from localhost ([::1]:49708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAA6W-0000x0-GR for larch@yhetil.org; Mon, 24 Aug 2020 06:53:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAA6O-0000wp-AQ for guix-devel@gnu.org; Mon, 24 Aug 2020 06:53:24 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57085) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAA6M-0004yp-4S for guix-devel@gnu.org; Mon, 24 Aug 2020 06:53:24 -0400 X-Originating-IP: 91.165.152.159 Received: from mimimi (91-165-152-159.subs.proxad.net [91.165.152.159]) (Authenticated sender: mail@ambrevar.xyz) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 35DCA20008; Mon, 24 Aug 2020 10:53:16 +0000 (UTC) From: Pierre Neidhardt To: Arun Isaac , Ricardo Wurmus Subject: Re: File search progress: database review and question on triggers In-Reply-To: <87blj0sayk.fsf@ambrevar.xyz> References: <87sgcuh8rb.fsf@ambrevar.xyz> <87y2ml429i.fsf@elephly.net> <87364tgja3.fsf@ambrevar.xyz> <87y2mlf4jw.fsf@ambrevar.xyz> <87pn7x3pyw.fsf@elephly.net> <87r1sbel4f.fsf@ambrevar.xyz> <87eeobh01d.fsf@systemreboot.net> <87d03uevdq.fsf@ambrevar.xyz> <875z9mhh3s.fsf@systemreboot.net> <87tux6d54k.fsf@ambrevar.xyz> <87zh6yfuin.fsf@systemreboot.net> <87r1sad0co.fsf@ambrevar.xyz> <87o8neczen.fsf@ambrevar.xyz> <871rk73dqw.fsf@systemreboot.net> <87blj0sayk.fsf@ambrevar.xyz> Date: Mon, 24 Aug 2020 12:53:16 +0200 Message-ID: <871rjws4bn.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=217.70.183.200; envelope-from=mail@ambrevar.xyz; helo=relay7-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/24 06:53:18 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, FROM_SUSPICIOUS_NTLD=0.498, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_PDS_OTHER_BAD_TLD=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: DXl9RLjHx0Tt --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >> - You should use SQL prepared statements with sqlite-prepare, >> sqlite-bind, etc. That would correctly handle escaping special >> characters in the search string. Currently, searching for >> "transmission-gtk", "libm.so", etc. errors out. > > Thanks for pointing this out, I'll look into it. I've looked into it. Actually the issue is not with the lack of sqlite-bind-arguments, but with "-" and "." triggering an error in FTS. I've fixed it in e08f913d20428a9a925cc46d177c7446f55e6443. The downside is that we can't use any special character like boolean operators. I'm not sure how we can get the best of both worlds. Maybe add a command line flag that would enable "extended search syntax" in which the user can use all of FTS but must make sure to quote "libm.so" for instance. Cheers! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl9DnBwACgkQm9z0l6S7 zH/SWggApnc+QAPH/2PSt9Xj0iNbMJYgLONQZihjvhWmWcaa7mGAlnhuChVu7VtK IBSzeTc4/2FsT7U37eVMERm8FoOGbELcmquNEvchczVmqPqmnBknEYwCaPA8varE +e6RNm9DEp3tjWYgFlhhUsLnZtyyHDjF2RuUZyg8aBiDbMnxqWhxD2NPZOhuFTst fBw8ewI7Q1fIL95T9W05lDrWbOrdqgb+uk7JSkQKR+2cI9EvQED1AX69cgpvvPSI IvSHabU+vbxn586ECqbtQodZFJ8JVFpBfhvqsBTd/RUhQKOPIkg66fZbp57WuIwB fhcKugo3o4l4lNXUGQsVsGP/J5/QKQ== =Jc3p -----END PGP SIGNATURE----- --=-=-=--