unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>, guix-devel@gnu.org
Subject: u-boot for beagleboard
Date: Thu, 01 Oct 2020 10:15:40 -0700	[thread overview]
Message-ID: <871rih7tqb.fsf@ponder> (raw)
In-Reply-To: <20201001110741.1bb8254c@primarylaptop.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]

On 2020-10-01, Denis Carikli wrote:
> I'd like to send a patch to add a bootloader (u-boot) package for a
> single board computer. The patch is trivial and it's already
> ready.

Great!


> However before sending the patch, I'm supposed to build it within Guix
> source code and to test it.

Can't help with that part right now...


> From 06a9dc65588a1b56add1188ba14fd5985a8a26d0 Mon Sep 17 00:00:00 2001
> From: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> Date: Sun, 27 Sep 2020 01:07:44 +0200
> Subject: [PATCH] gnu: Add u-boot-beagleboard.
>
> * gnu/packages/bootloaders (u-boot-beagleboard): New variable.
> * gnu/bootloader/u-boot (install-beagleboard-u-boot): New variable.
>   (u-boot-beagleboard-bootloader): New variable.
> * gnu/system/install (define beagleboard-installation-os): New variable.
...
> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
> index d1de5cea4e..2b90fab895 100644
> --- a/gnu/packages/bootloaders.scm
> +++ b/gnu/packages/bootloaders.scm
> @@ -685,6 +685,9 @@ it fits within common partitioning schemes.")
>  (define-public u-boot-am335x-evm
>    (make-u-boot-package "am335x_evm" "arm-linux-gnueabihf"))
>  
> +(define-public u-boot-beagleboard
> +  (make-u-boot-package "omap3_beagle" "arm-linux-gnueabihf"))
> +

This package and related variables should be named
"u-boot-omap3-beagle". I think most u-boot targets follow this
convention(naming it after the defconfig target), so it would keep
naming consistent.

Maybe make-u-boot-package should be extended to support passing a list
of "common" names for boards, which could then be appended to the
description?


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  parent reply	other threads:[~2020-10-01 17:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01  9:07 How to build Guix to send a patch when Guix build fails? Denis 'GNUtoo' Carikli
2020-10-01 13:54 ` zimoun
2020-10-01 23:19   ` Denis 'GNUtoo' Carikli
2020-10-02  8:08     ` zimoun
2020-10-01 17:15 ` Vagrant Cascadian [this message]
2020-10-04 18:34   ` u-boot for beagleboard Danny Milosavljevic
2020-10-05 10:35     ` Miguel Ángel Arruga Vivas
2020-10-05 13:55       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rih7tqb.fsf@ponder \
    --to=vagrant@debian.org \
    --cc=GNUtoo@cyberdimension.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).