From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gJ43CXJc6V+BLAAA0tVLHw (envelope-from ) for ; Mon, 28 Dec 2020 04:17:54 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0JoIBXJc6V9kHAAAbx9fmQ (envelope-from ) for ; Mon, 28 Dec 2020 04:17:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CDF399402A2 for ; Mon, 28 Dec 2020 04:17:53 +0000 (UTC) Received: from localhost ([::1]:54690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktjyi-0007LQ-Pt for larch@yhetil.org; Sun, 27 Dec 2020 23:17:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktjyZ-0007LH-GX for guix-devel@gnu.org; Sun, 27 Dec 2020 23:17:43 -0500 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:44345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktjyX-0005CH-3F for guix-devel@gnu.org; Sun, 27 Dec 2020 23:17:43 -0500 Received: by mail-pl1-x634.google.com with SMTP id r4so5050689pls.11 for ; Sun, 27 Dec 2020 20:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=oE5NV/jylBBIZmNhd7VhtrtDarvLR0wXeGVJZHGTiDg=; b=rbICKDtr527nf7oOfH5ULU2fvooxKyDq7fLVfJAS2DJtgdWtfoC29WmfFiGWT98lqE qFW/krKF2A1XX7bcJGcxyZSMI6S5J/+RPTAT5mEFBREUjdj3aDwBlWzyQFrlgXCHLTF2 5YhJnNgEQHVaY0UFpx1K1++JNwBmT2SetuJhgty7MY6a/TKhx+kewXE6A9PzACX8YSgH PW/2D1CWZlDgLe++4XlxkzEo1yMVu+kxA27i6bz87YRENEB03DYXPx1zLfEnxNuH3KL0 xwTzlRSxOKGGuvO5SyJKubTV7O8M3qTXb2jmGAV/6Nl2Q7KlK2KFPT2o7ATNDBdTItk/ hHpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oE5NV/jylBBIZmNhd7VhtrtDarvLR0wXeGVJZHGTiDg=; b=luAUfkOLdPotGXKJckmwsdQbzi3rxr3u0dq9YHZTz7pbfA8uU7Xm8Ue19wFIIFnz8B OAur7lI/FPtnYD3DLXXnLm7rcpijoI7vTxS/mKfSZp7zsyiunWgS8CalSB8t+0aEypP2 6uzs04j74wokrCoy+QBsIcSKXOdE+Evo5Kxkh/fW4+ScB0gtTDhoFN3zSYbAFr1T2Vfd L71+6adXQaW6Y/bp5LwJbujJZjZvw9lsObxDiG36peAOg+wXaQwgCd2wqjhksiDfzZVr cMdlF1+KMXXDLBo6cYAB7mhNZJdGY1HxkerWgL28DpJve6uT8gWscUes6R2zGFAmf80L UdPw== X-Gm-Message-State: AOAM531IJoRxiTthdRKUhAW7OVGGYE0i2WJOgbLq671LLa3AVv1CDb3H /sIsCjDMhh3DiOAbbb6MPTI= X-Google-Smtp-Source: ABdhPJz4Prhg1u/FHwiPYKnFTZE5Hrg7zweIGCQdTR4bWQZzVVqkTiOyLCzxYuphnz2FbplYr+qi3A== X-Received: by 2002:a17:90a:e38c:: with SMTP id b12mr19535331pjz.177.1609129058734; Sun, 27 Dec 2020 20:17:38 -0800 (PST) Received: from garuda-lan ([2601:601:9d00:688::c9a]) by smtp.gmail.com with ESMTPSA id j14sm12362212pjm.10.2020.12.27.20.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Dec 2020 20:17:37 -0800 (PST) From: Chris Marusich To: Efraim Flashner , Mark H Weaver Subject: Re: [bug#45252] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le., [bug#45252] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le., [bug#45252] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le. References: <87y2hqifp3.fsf@netris.org> <87tuseidlk.fsf@netris.org> <87r1nhdo2i.fsf@gmail.com> <87y2hqifp3.fsf@netris.org> <87tuseidlk.fsf@netris.org> <87r1nhdo2i.fsf@gmail.com> <87y2hqifp3.fsf@netris.org> <87tuseidlk.fsf@netris.org> <87r1nhdo2i.fsf@gmail.com> Date: Sun, 27 Dec 2020 20:17:33 -0800 In-Reply-To: (Efraim Flashner's message of "Wed, 23 Dec 2020 09:50:27 +0200, Wed, 23 Dec 2020 16:34:29 -0500, Wed, 23 Dec 2020 16:22:21 -0500") Message-ID: <871rfa36oy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=cmmarusich@gmail.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, John Doe , 45252@debbugs.gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.68 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=rbICKDtr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: CDF399402A2 X-Spam-Score: -0.68 X-Migadu-Scanner: scn0.migadu.com X-TUID: TtLHERpobtN6 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Efraim Flashner writes: > "regular powerpc", ie macppc/ppc32/powerpc-linux-gnu, does have some > bootstrap binaries built but isn't near ready for merging. Go ahead and > make any changes necessary. Mark H Weaver writes: > Hi Efraim, > > Efraim Flashner writes: >> "regular powerpc", ie macppc/ppc32/powerpc-linux-gnu, does have some >> bootstrap binaries built but isn't near ready for merging. Go ahead and >> make any changes necessary. > > I appreciate that, but if rebuilding the world on regular powerpc would > significantly add to the burden of even a single developer, then it's > probably not worth it. I suggested fixing the powerpc64le case now only > because it was just added a few days ago, and more generally to raise > awareness about how best to run the 'patch' program in Guix. > > If it's truly no extra burden, then you could change "--batch" to > "--force" on line 69 of libffi.c (in the "powerpc-*" case). OK. I've made this change on master in commit 662e7e28d576ada91fc9dec7d27c100666114f03. Mark H Weaver writes: > Hi Chris, > > Chris Marusich writes: > >> Mark H Weaver writes: >> >>> Earlier, I wrote: >>>> When invoking 'patch' in Guix, you should *always* use "--force" inste= ad >>>> of "--batch". >>> >>> (See for my earlier message). >> >> Thank you for letting me know about this. I didn't know about the >> difference between "--batch" and "--force". I agree we should use >> "--force" instead of "--batch". How do you recommend that I proceed? > > Simply changing "--batch" to "--force" on line 79 (in the powerpc64le-* > case, i.e. the one that was just added) seems like the right thing. > That will force a rebuild of almost everything on the powerpc64le-* > architecture, but should not cause any rebuilds on other architectures. OK, I've made this change on master in commit fdb90e9ee8a578c88ef3a33067e8a532e43ae7b8. >>> Since writing the message above, I've found another problem in the same >>> commit (7eaa2f24ea77cddbb4bbc2d6a6905673a36f8f99): it searches for the >>> 'patch' program in 'inputs'. This is a mistake, because when >>> cross-compiling, 'inputs' will contain software compiled to run on the >>> target system instead of the build system. >> >> Is it searching for the "patch" program, or is it searching for the >> patch file? It looks to me like the code is searching for the patch >> file in inputs, not the "patch" program. > > LOL, you're right, I got confused. Please disregard my second email in > this thread, and apologies for that noise. No worries! Thanks again for your help. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAl/pXF0ACgkQ3UCaFdgi Rp1ioQ//W6XnPvkS0isAW+iOAObLeWcNmjN91bKJFKvmNPIxEb2tyVOda/Lv5dJp NFFOziVorczwIORpRJqPSdXIhOfq+bU6ZN9RfY8d20f3Zs7AH7N/rvH7PQUx+N9L GcDHMsDV+fTycgnU9bwPo6q5GGfd9TQy5FGABa5bTsRjCabb/W4iWVW2Vbh3ZVIn PjVmYjq27lLwWTBhyix7GA37sGkIHfm8C4NOFuGaiId9sx5UYjO8nu9vtES53Wq6 frCZ+UHjP2zMfaDA68Q0VonaHA3uqTGpxqdA0EzBJukleDsSl5Tzjnk5MPDGPaHx m/pCoD32IEjOM0q1EWz2EMoop6hackMhtbFVcy7tM06ili4A/XX7I0b2bpZhsbCj 8gbDvNyZqr9w01K1HVyAsepaXzNfV8cNOxAyoQKcFGxUvV+F+EOZPv1eKWEh6ZFd p+h1iJnsjY/xvrCwwh0rTgkw/P4k0o32dROMhF/lqS79pWxFLkXId+kNwwum84Cg 1vhnjpSRIBx5W6c6+xavQovAaSNC9TpuirKeszeG5y6mUpxjAC31oGAI+6NYlJb5 Vw/gQKvVylIS6ma0KkcHlIzcSqqcNX8DlczsV8w5lW+RuzTQ8D5PblFH1zngEH0Y Dgcb/C3BnR1uPUbO4S8IpAv1r2YfaYBlA2146iGn7RGQIHuINt0= =bxVh -----END PGP SIGNATURE----- --=-=-=--