From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AG8YLbOHaWBrywAAgWs5BA (envelope-from ) for ; Sun, 04 Apr 2021 11:32:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GLDyJrOHaWAUOAAA1q6Kng (envelope-from ) for ; Sun, 04 Apr 2021 09:32:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 561CF25C39 for ; Sun, 4 Apr 2021 11:32:35 +0200 (CEST) Received: from localhost ([::1]:52608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSz7S-0001Gt-FM for larch@yhetil.org; Sun, 04 Apr 2021 05:32:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSz7J-0001Gj-8P for guix-devel@gnu.org; Sun, 04 Apr 2021 05:32:25 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:51888 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSz7G-0004Rd-Ri for guix-devel@gnu.org; Sun, 04 Apr 2021 05:32:24 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1617528730; bh=i1yPTnTmwHzdGIxPqaOv9IRK7gL6NyW2SB2tw5F5B+o=; h=From:To:Subject:In-Reply-To:References:Date; b=mXznB3z0wv9GnwOE3ZxbbxwWBZbXwdsx2cxHM7jU6wdy2ZX6G4+EdILmU/97e1LG1 exAsVZu1pE5K/fb74/h6ymjRzgbBW15hSQddoB664Ue9l3pSJkw9zEQkTguZiqsm2N mWq89iuGEHCwA5HjUJnD2mzqE3fciLf+9BPepW4Q= To: Leo Prikler , guix-devel@gnu.org Subject: Re: A new wip-emacs branch In-Reply-To: <04ca8e13c39b4e1e41a10a5d77250391cfb001b5.camel@student.tugraz.at> References: <92b90b2aa6ed7d61beba38ff123b8bf1c0695234.camel@student.tugraz.at> <87pmzbwqcu.fsf@yoctocell.xyz> <87lf9zwpgy.fsf@yoctocell.xyz> <04ca8e13c39b4e1e41a10a5d77250391cfb001b5.camel@student.tugraz.at> Date: Sun, 04 Apr 2021 11:32:08 +0200 Message-ID: <871rbqwg2v.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5, PDS_OTHER_BAD_TLD=1.999, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617528755; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dNfC/KecwxPBtj02X1qfh4uKX8H+LxEyeK8kcWN+4Vo=; b=beBtIZEU/hMAPVxcEVu3es7IdWfTlk5HfOlNHs67MHrDO7dcbJ0obKJGbFwbVjJISviGi1 w7vpdpoPhc8IXj9SDJesQ/a34PTUXyzZkovhfrHFK3qvWwKBaLEJue8c4j2NZsoZJTuG6g Yw/wl+sGxApdGRheuHkU5PaQk5JMd+9r2UjSWPfVAvU+M/hk2TpBv0WPYBFDU1kyMDbSlO pKRaT0NK9jZbcMuIZlIVjFG5EFbp1h7Bygl3y7nR8XmZdlRpb2PAb8sT8Pt19chNg2Aalh Wiok5hFIv0oYiUERAVCb0ZIISoNy0tW2G1IM77F00Wgu9Ebidlus7+NH77SOiQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617528755; a=rsa-sha256; cv=none; b=XzUBMr4f8W32XZR6/y5s0IVhb7otgyL9JLZP0uuue1n1YIDZNrL3U19k4dBGJXRv8+4oTk 2gNh7zCacuwocNZTnGm2ITfLO7ElPjbyfKe32mK3yH1cRDWCFVDDp3d95tgnXMUhmZADog C9O86Gi0txyXqX8keI4KBQnvkUSfClllJbxtkyZYrcuTCNx5CXHKcW2+LiAqQ0IA5XLeRg 3zS+Ui7vZJGipQXxWCZVykzwbpxfsqgNQSwhefYGDp4Qc+2Tj+DSB9Cjo3EUr9F4uYzL2k MwQxf9aNMI4G1lbE+nfRwdAXZ3giRVnz71GsCSYBGvQE0UoxUBPatVqkQPpk9Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=yoctocell.xyz header.s=mail header.b=mXznB3z0; dmarc=pass (policy=none) header.from=yoctocell.xyz; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.14 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=yoctocell.xyz header.s=mail header.b=mXznB3z0; dmarc=pass (policy=none) header.from=yoctocell.xyz; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 561CF25C39 X-Spam-Score: -3.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4QFI3/Y21xMN --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Apr 03 2021, Leo Prikler wrote: > Your patch LGTM in a vaccum (except that package-version this-package > could be abbreviated to just "version" IIUC), but I went for a > different fix, since emacsql tried to avoid redundancies by putting in > other redundancies. > > I ran a small test with emacs-emacsql-sqlite on > 2be3daa19d2fd47933c622995d2f2dde714075e6, but please try it for > yourself and check whether everything works as you expect it to. Thanks for fixing the problem, but now I noticed that 'emacs-pdf-tools' doesn't build. --8<---------------cut here---------------start------------->8--- starting phase `emacs-add-source-to-load-path' Backtrace: 7 (primitive-load "/gnu/store/g7vcnpqrs3p76qm9xrnm1sz65ss=E2=80= =A6") In ice-9/eval.scm: 191:35 6 (_ _) In guix/build/gnu-build-system.scm: 838:2 5 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . #) In ice-9/boot-9.scm: 1736:10 4 (with-exception-handler _ _ #:unwind? _ # _) In srfi/srfi-1.scm: 857:16 3 (every1 # =E2=80=A6) In guix/build/gnu-build-system.scm: 847:30 2 (_ _) 847:30 1 (_ _) In ice-9/boot-9.scm: 1669:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1669:16: In procedure raise-exception: Wrong type to apply: #f note: keeping build directory `/tmp/guix-build-emacs-pdf-tools-0.90-1.c5104= 42.drv-0' builder for `/gnu/store/d992q7cfb1wlfffg15g7bgsa32qjanrm-emacs-pdf-tools-0.= 90-1.c510442.drv' failed with exit code 1 build of /gnu/store/d992q7cfb1wlfffg15g7bgsa32qjanrm-emacs-pdf-tools-0.90-1= .c510442.drv failed View build log at '/var/log/guix/drvs/d9/92q7cfb1wlfffg15g7bgsa32qjanrm-ema= cs-pdf-tools-0.90-1.c510442.drv.bz2'. guix build: error: build of `/gnu/store/d992q7cfb1wlfffg15g7bgsa32qjanrm-em= acs-pdf-tools-0.90-1.c510442.drv' failed --8<---------------cut here---------------end--------------->8--- The attached patch fixed the problem for me. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-pdf-tools-Adjust-to-changes-in-emacs-build.patch Content-Description: wip-emacs-fix-emacs-pdf-tools >From b49dd5be93bb5ba9630dca8d5bb142f258cb0781 Mon Sep 17 00:00:00 2001 Message-Id: From: Xinglu Chen Date: Sun, 4 Apr 2021 11:28:04 +0200 Subject: [PATCH wip-emacs] gnu: emacs-pdf-tools: Adjust to changes in emacs-build-system. * gnu/packages/emacs-xyz.scm (emacs-pdf-tools)[#:phases]: Rename 'add-source-to-load-path' to 'expand-load-path'. --- gnu/packages/emacs-xyz.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 0382cfdd17..9dbfce6f37 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -2920,7 +2920,7 @@ during idle time, while Emacs is doing nothing else.") (emacs-substitute-variables "pdf-tools.el" ("pdf-tools-handle-upgrades" '())))) (add-after 'emacs-patch-variables 'emacs-add-source-to-load-path - (assoc-ref emacs:%standard-phases 'add-source-to-load-path)) + (assoc-ref emacs:%standard-phases 'expand-load-path)) (add-after 'emacs-add-source-to-load-path 'emacs-install (assoc-ref emacs:%standard-phases 'install)) (add-after 'emacs-install 'emacs-build base-commit: 2be3daa19d2fd47933c622995d2f2dde714075e6 -- 2.31.1 --=-=-=--