From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QELGIN5ZfGBouQAAgWs5BA (envelope-from ) for ; Sun, 18 Apr 2021 18:10:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kPaoG95ZfGDjDQAA1q6Kng (envelope-from ) for ; Sun, 18 Apr 2021 16:10:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 87A70184A1 for ; Sun, 18 Apr 2021 18:10:03 +0200 (CEST) Received: from localhost ([::1]:36172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lY9zl-0004O3-Tc for larch@yhetil.org; Sun, 18 Apr 2021 12:10:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lY9zc-0004Nw-Tk for guix-devel@gnu.org; Sun, 18 Apr 2021 12:09:52 -0400 Received: from world.peace.net ([64.112.178.59]:57522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lY9zb-00049c-0K; Sun, 18 Apr 2021 12:09:52 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lY9zN-00012R-CW; Sun, 18 Apr 2021 12:09:37 -0400 From: Mark H Weaver To: Mathieu Othacehe , Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: wip-ungrafting builds stuck In-Reply-To: <874kg3rjay.fsf@gnu.org> References: <87sg3nnc6f.fsf@gnu.org> <874kg3rjay.fsf@gnu.org> Date: Sun, 18 Apr 2021 12:07:52 -0400 Message-ID: <871rb7tw24.fsf@netris.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618762203; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=YKLOS3RSGFfKWwLIkznZovXuH8Su+We1QVFGgbe3pNI=; b=Qs88qdHjy9CQmFpwDM3iT8to7LB+FcSzut2M0KafiPWrppwdtVJotMM0vTsdmK+3xlpSkD osIHeXVgiZy8OyaDfN97z8QgetU+QeGshSRnfsMBnoowkFxLzMU2eQW1gBOj1JjsKK9eE+ LgTklpm74Nk/H+xNSXBWRRbJO+bkhZ7Yv1IAiBdTS1SiDOD+ca+wRC5BQVPqVgDYLz+2kp vxixMBHqhTzl8n/XjCoCWeh2WKH1UZ2nZvSSFESZvCDhtRJnsp7URTO/Edjw2FQI/13fif gX7uG3kwncm5Wi9yIQ/SCXI6QOt7LocACGEBlrOcCdMbyRPF32U+BxARJJqQbA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618762203; a=rsa-sha256; cv=none; b=IgnPe9zULl797BeCDHRfe0C9v2aRhnY9rVIe7fbQJzry/A3rd/dKssUbaI5NXk51WTSm2P bCO/TfPP8il03Fv8oAUSybo4JRuiHJ2VRier4cRXEdv+4uUzgstz+UP9+5V//AtdDxC88E bvQWgfpBJrQPMqaeT3vHSnAQPhXrGw0HVmzP+XGNWrjeOnHNPWV+mglxYSUf4ThIdofKox 6gZRpkuPUDO35/oZON1fCBicXq7EVpHJ7lOBqxyrlG7xjp9XOhbE8KFrU0NNWT/+VFEcsC YlbleSXlk3nPEXGS+NYTUoqI0hNYE9McXmcmGGSLYUjczbh017TEKVYzhCqUnA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 87A70184A1 X-Spam-Score: -2.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: PtOXc6DFU1Xj --=-=-= Content-Type: text/plain Mathieu Othacehe writes: >> Any idea what could be wrong, Mathieu? What would you suggest to do >> when investigating such issues? > > Yes I noticed it. The main problem here is that almost all workers are > stuck building Rust. > > I see two actions here: > > 1. Understand why Rust is taking so long to build. The attached patch, which I've been using on my private branch of Guix for a long time and is fully tested, would significantly speed up the Rust bootstrap. I never submitted it because I wasn't sure it would be of interest. Mark --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-rust-Disable-check-phases-of-versions-before-1.4.patch Content-Description: [PATCH] gnu: rust: Disable check phases of versions before 1.40. >From cfe7ed9732e77eacf7f9e6b6db0d731b2f7d100e Mon Sep 17 00:00:00 2001 From: Mark H Weaver Date: Sun, 19 Jul 2020 23:13:28 -0400 Subject: [PATCH] gnu: rust: Disable check phases of versions before 1.40. This saves 49 hours of total build time on a Thinkpad X200. * gnu/packages/rust.scm (rust-1.19)[arguments]: Add "#:tests? #f". (rust-1.20, rust-1.26)[arguments]: Modify the custom 'check' phase to honor the '#:tests?' argument. (rust-1.40)[arguments]: Override '#:tests?' argument to be #t. --- gnu/packages/rust.scm | 40 ++++++++++++++++++++++++++-------------- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/gnu/packages/rust.scm b/gnu/packages/rust.scm index 3952a17908..2b9f26c204 100644 --- a/gnu/packages/rust.scm +++ b/gnu/packages/rust.scm @@ -236,6 +236,8 @@ safety and thread safety guarantees.") (arguments `(#:imported-modules ,%cargo-utils-modules ;for `generate-all-checksums' #:modules ((guix build utils) (ice-9 match) (guix build gnu-build-system)) + #:tests? #f ;Disable the test suite for early versions of rust to save + ;compile time. #:phases (modify-phases %standard-phases (add-after 'unpack 'set-env @@ -596,11 +598,16 @@ jemalloc = \"" jemalloc "/lib/libjemalloc_pic.a" "\" (invoke "./x.py" "build") (invoke "./x.py" "build" "src/tools/cargo"))) (replace 'check - (lambda* _ - ;; Disable parallel execution to prevent EAGAIN errors when - ;; running tests. - (invoke "./x.py" "-j1" "test" "-vv") - (invoke "./x.py" "-j1" "test" "src/tools/cargo") + (lambda* (#:key (tests? #t) #:allow-other-keys) + (if tests? + (let ((parallel-job-spec + ;; Disable parallel execution to prevent EAGAIN + ;; errors when running tests. + "-j1")) + (invoke "./x.py" parallel-job-spec "test" "-vv") + (invoke "./x.py" parallel-job-spec "test" + "src/tools/cargo")) + (format #t "test suite not run~%")) #t)) (replace 'install (lambda* (#:key outputs #:allow-other-keys) @@ -774,15 +781,16 @@ jemalloc = \"" jemalloc "/lib/libjemalloc_pic.a" "\" ;; binaryen was replaced with LLD project from LLVM (delete 'dont-build-native) (replace 'check - (lambda* _ - ;; Enable parallel execution. - (let ((parallel-job-spec - (string-append "-j" (number->string - (min 4 - (parallel-job-count)))))) - (invoke "./x.py" parallel-job-spec "test" "-vv") - (invoke "./x.py" parallel-job-spec "test" - "src/tools/cargo")))) + (lambda* (#:key (tests? #t) #:allow-other-keys) + (if tests? + (let ((parallel-job-spec + ;; Enable parallel execution. + (format #f "-j~a" (min 4 (parallel-job-count))))) + (invoke "./x.py" parallel-job-spec "test" "-vv") + (invoke "./x.py" parallel-job-spec "test" + "src/tools/cargo")) + (format #t "test suite not run~%")) + #t)) (replace 'remove-unsupported-tests (lambda* _ ;; Our ld-wrapper cannot process non-UTF8 bytes in LIBRARY_PATH. @@ -1226,6 +1234,10 @@ move around." ;; which makes this workaround only necessary for this release. (cons* #:validate-runpath? #f (substitute-keyword-arguments (package-arguments base-rust) + ((#:tests? _ #t) + ;; Enable the test suite, which was disabled for earlier versions + ;; of rust to save compile time. + #t) ((#:phases phases) `(modify-phases ,phases ;; We often need to patch tests with various Guix-specific paths. -- 2.31.1 --=-=-=--