From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mICTK1WogWCLCQAAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 18:46:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4N5GJ1WogWAbXQAAB5/wlQ (envelope-from ) for ; Thu, 22 Apr 2021 16:46:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 35BD41CEB1 for ; Thu, 22 Apr 2021 18:46:13 +0200 (CEST) Received: from localhost ([::1]:32944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZcSw-0004Nt-Us for larch@yhetil.org; Thu, 22 Apr 2021 12:46:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZcD5-0006Pl-Ts for guix-devel@gnu.org; Thu, 22 Apr 2021 12:29:47 -0400 Received: from world.peace.net ([64.112.178.59]:37750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZcD3-0003ES-TW; Thu, 22 Apr 2021 12:29:47 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZcCx-0004Yl-VI; Thu, 22 Apr 2021 12:29:40 -0400 From: Mark H Weaver To: Leo Famulari Subject: Re: Why is glib still grafted on the 'wip-ungrafting' branch? (was Re: wip-ungrafting builds stuck) In-Reply-To: References: <87sg3nnc6f.fsf@gnu.org> <87a6pr2wm2.fsf@netris.org> Date: Thu, 22 Apr 2021 12:27:52 -0400 Message-ID: <871rb21dy4.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel , Mathieu Othacehe , Maxim Cournoyer Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619109973; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=Bdh+4hHxUq+yLqLpK2lXQAghNLzvaXV87PUPUg6qn0s=; b=kocFhuuR9NaY7FRHVVdOyKZPNqoyhJKKEAfzpLCLT7buujmhO8Tw/jfdWfHuNeeEI1VxqL jY7fgnsCXuTRNYGfO+xMOnGuxoCsfPcVhKP6T25YX1kvGl2DL+N4rX4SZvEFg73vjnovi7 0HEYaYwJPukjIj8PA3Qi/u4eW/w2iRQgn9qCcLSSd95w0Ls5UhZC0zQ2jpxuOW0WK3z5kt LTtMv3i8Uq8eaog0hsz+16xsVQIvZJ1HXgS/fs+tW77XeLkpyDizjPfakxyfYrLX0H3SNT oxivJYZ7bHTWLJFD/Kk3CQeuQ/yfgqmsZIwmDEaAldAOmKZFKrSyb2yDQN6tgQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619109973; a=rsa-sha256; cv=none; b=XajflKb9BtaIpXMT2I+Tb2MFx7EFWi4TxXTjwqJ5aybtGK/iD+Tv12IPX3wowmxOaJWx+u rTDyivZD+s0s4occued/5uTgeeS+CrDLurcZpOXaPEydgAegtt/OXTWVJMGjlE06/pccGi uHRwztaJOxCrf0T+jW2iRPZ+aIC2wbsg2yi/hCTdTRadBuOQyHFCfGKtQB5Dq8sDeTg9kN Sq6rLXNLcNoU5i6ICk/JajUPCTbbo/ml73coRky4WRwmr3aEiQ955sE+yQKBeokfZDQNC9 qX0ErIMtYq2lqF20T+nyRqin4css2Ka0aByU2XixKRMuQWNn2yHl/hQnWCPEKg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 35BD41CEB1 X-Spam-Score: -0.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: T+u6BJbXmnLz Hi Leo, Leo Famulari writes: > On Wed, Apr 21, 2021 at 04:47:06PM -0400, Mark H Weaver wrote: >> I just noticed that 'glib' is still grafted on the 'wip-ungrafting' >> branch. Was that intentional? >> >> https://git.sv.gnu.org/cgit/guix.git/tree/gnu/packages/glib.scm?h=wip-ungrafting&id=e12210dc92098d8581cea3007d57dbb6be16bb41#n171 > > Yes. For that branch I only selected grafts that I judged to be > "simple". There are many other grafts still in place on that branch. Okay, thanks for the explanation. > My criteria for simplicity are grafts that either apply one or two > patches, or are minor version upgrades of projects that are known to > care about ABI compatibility. I don't understand why it's relevant how many patches are involved. It sounds like if I had concatenated all of the CVE-2021-27219 patches into a single file, you would have judged that as "simple", and therefore ungrafted it, although it makes no substantive difference. Anyway, it makes no difference to me; I'll continue doing my own thing on my private branch. I just wanted to make sure that it wasn't an oversight. Thanks, Mark