From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mO4bNfeyOGHxxAAAgWs5BA (envelope-from ) for ; Wed, 08 Sep 2021 14:56:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WJHqMPeyOGEVOQAAB5/wlQ (envelope-from ) for ; Wed, 08 Sep 2021 12:56:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C9842AC2B for ; Wed, 8 Sep 2021 14:56:23 +0200 (CEST) Received: from localhost ([::1]:38970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNx7m-0007zK-3y for larch@yhetil.org; Wed, 08 Sep 2021 08:56:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNx7b-0007ys-Ue for guix-devel@gnu.org; Wed, 08 Sep 2021 08:56:11 -0400 Received: from mout01.posteo.de ([185.67.36.65]:48889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNx7Y-0005po-QO for guix-devel@gnu.org; Wed, 08 Sep 2021 08:56:11 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 7E71224002A for ; Wed, 8 Sep 2021 14:56:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1631105766; bh=er4lbH4kbdP2arpmLcarZ6X9Z+0FA6msTAc4MkCqDdY=; h=From:To:Cc:Subject:Date:From; b=CBWP2oJtJ91vU9D/0y23RLKMQxTRdayLzrDTDzX91t2Ddk+SB7DWkUfR3I7ZPzZN1 mK1zlTUuobrQlLcGqLnobBgjb31w80xPYrfaoYKxQ4vWHGtlhK1bKhx7Jv5WY1wBI6 sfkD2db80tKc+/QKu8ZoifYHNB/f3bwFf1fnx60U0JvcamkjfEzLYrTF6HZEMeuQwX C7B4CawVlMuu/sJ2hJtgmetIASxWVhG9LtwWuNccOXwY+PuULSsryQI+jXm3CEeIkQ qHe8GHr8llktyzrTt/eotrxZpEvTvQsPm0PiterH8XCg25mXs1ZlcYAX+pdYFzvUvf Njvg8e52Y3uwg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4H4MZY3kvkz9rxM; Wed, 8 Sep 2021 14:56:05 +0200 (CEST) References: <87fsuh4rsb.fsf@kitej> <87o894iad7.fsf@kitej> From: Guillaume Le Vaillant To: Leo Famulari Subject: Re: [core-updates-frozen] Bug in binutils 2.37 Date: Wed, 08 Sep 2021 12:50:45 +0000 In-reply-to: <87o894iad7.fsf@kitej> Message-ID: <871r5zdy58.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=185.67.36.65; envelope-from=glv@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631105783; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=er4lbH4kbdP2arpmLcarZ6X9Z+0FA6msTAc4MkCqDdY=; b=fl5eur3hZXHCw7KMmltbcVvqtCmwgwwGhGULmZmdyii/4aVrtq3viBMyweVfAm0FDKMqaL GxtcJdvmtEvItFzo6NhspTDwAUV6lzkqdRs9OnKo2loAbZsRpkWy20Hi0vH9ZPnbfC7Gfa cxA3AXLAFTykMdcuGt/jKoBm62B87TT8W9pBR5i0nECcwPtMvL9bwKZJ9a+2e3gxwh7lKe jropwYyomEJtvMmJ+wNn1L39DYAhAjNm7A+rF29D3FYaX41Kl/ZBYDtf811Ezq93hzruif w5oDlTHCGPx3BZWYpBxEuBIcntvsfT014A/Pczqy9/Kw+BoxoPOfIqmDizYzuQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631105783; a=rsa-sha256; cv=none; b=cUcRcAAzVDE8P3VZeNyWeoCVhGAByMIBgQ14Ijt0bZfgP9dbwgig3J86x8AqJeni/u/RYi PKX4/xSB5iqXk0V5paWqJpXIqs6rVtu8zjwE6bJhDFaX7d093z0L0/W2UqyDG8248Zjime wOWnF59O6Z2EYq3yJrhDbtkcDkVX3lyx8WLpnSGrXGgeX/CijWHwOGd/Jwyqn8d0vXDwbe JS3OG5+sDO67nDmB/cajIRc4sRW1Vj74Do3UmNFpWVDINE6nbq+GKVjbG6Ku4FsfWmo9rm oAkI1nPwNwlxK+qd/dwQh6b/mdWB6iNOMkcsyIDGJe4Jay7SidDdJX5kcpCXVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CBWP2oJt; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.21 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CBWP2oJt; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 1C9842AC2B X-Spam-Score: -2.21 X-Migadu-Scanner: scn0.migadu.com X-TUID: BSZiJMy7U2As --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Guillaume Le Vaillant skribis: > Leo Famulari skribis: > >> On Mon, Sep 06, 2021 at 03:39:52PM +0000, Guillaume Le Vaillant wrote: >>> There's a bug in binutils 1.37, which we are using on the >>> core-updates-frozen branch. >> >> 2.37, right? :) >> > > Indeed. :) > > >>> It's a file descriptor leak that can lead to 'malformed archive' errors >>> when linking libraries. We get this problem at least when building >>> qtwekbit and qtwebengine. A workaround allows us to compile qtwebkit >>> (see [1]), but it doesn't work for qtwebengine. >>>=20 >>> The bug was discussed at [2] and upstream has a patch to fix it at [3]. >>> However, adding this patch to our binutils rebuilds the world. >>> I'm currently trying to build things with the patched binutils. >>> If everything works, should I push this fix on core-updates-frozen, or >>> does someone have an idea that would lead to less rebuilds? >> >> There are a few options: >> >> 1) Apply the patch in the normal way and rebuild the world. If the >> changes in the patch are limited to fixing this bug, then we can be >> confident that changing binutils will not break other packages, which is >> the main goal behind "freezing" the core-updates branch. Do you think >> that expectation is reasonable? Otherwise, the branch is frozen except >> for bug fixes; we'd like to avoid rebuilding the world but it's not a >> problem if we have to. >> 2) Create a binutils-fixed package and only use it for qtwebkit and >> qtwebengine >> 3) Try to work around the bug in the qtwebkit and qtwebengine packages >> >> 2 and 3 are not great because maybe the bug affects other packages in >> some situations. Do you know if it manifests deterministically? > > The problem happens when linking a library with a lot of members (I > don't know exactly how many), which is the case at least for qtwebkit > and qtwebengine. Users creating such libraries in their projects will > also have the problem. > > Increasing the maximum number of open file descriptors seems not be > a very robust workaround. Setting it at 4096 for qtwebkit works, > but I tried 4096, 8192 and 16384 for qtwebengine and it didn't work. > > I have built many packages with the patched binutils and I didn't get > any new failure so far. I'm not yet at qtwebkit and qtwebengine though > (compiling the 20 versions of rust took a while). > So when I get there, and if the patch really solves the issue, pushing > it looks like the best solution. > > Do you know if there are other world-rebuilding pending fixes that could > go in at the same time? I confirm that the patch fixed the compilation issues for qtwebkit and qtwebengine, and it didn't cause new build failures, so I pushed it as de8e2a699c0219f5ea86f6bbfff4d5ee35104738. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYTiy4w8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j/gfQD+Pfq4WyIfg7ixOh91DEn/3m8MzDXu9/coEhO/ d83KDfgA/2GXMH6QfooBdM+CM8m3gTEjciQQUIXzldiMFYq2A/e+ =1gNO -----END PGP SIGNATURE----- --=-=-=--