unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Demis Balbach <db@minikn.xyz>
To: Josselin Poiret <dev@jpoiret.xyz>, guix-devel@gnu.org
Subject: Re: bluetooth-service: addition config vaules
Date: Sat, 11 Dec 2021 18:02:46 +0100	[thread overview]
Message-ID: <871r2jt6q1.fsf@minikn.xyz> (raw)
In-Reply-To: <87k0gbfdmq.fsf@jpoiret.xyz>

[-- Attachment #1: Type: text/plain, Size: 1948 bytes --]

On 2021-12-11 14:57, Josselin Poiret wrote:

> I think this is pretty approachable, especially given the fact that you
> don't need to write the whole service from scratch.
>
> All of the following takes place in gnu/services/desktop.scm: the
> options given to the service via the bluetooth-configuration record end
> up being inserted into the gexp that the bluetooth-directory procedure
> returns, which is itself used to build the actual /etc/bluetooth/
> directory for the system (see "G-Expressions" in the manual if you want
> more info about gexps, although you won't need to manipulate them for
> this).  The contents of the main.conf file are generated with the
> bluetooth-configuration-file procedure, which contains only basic string
> manipulation.
>
> So, in order to add new options to the bluetooth service,
> you would need to only modify the bluetooth-configuration record to add
> them, with proper defaults, as well as add the relevant lines in
> bluetooth-configuration-file.  As to testing, you could simply run `guix
> system build some-test-system-conf.scm` and check that the resulting
> /gnu/store/xxxx-system/etc/bluetooth/ folder contains the proper
> configuration file.  Ideally, you would also test if the features
> themselves end up working properly, but I am hopeful that bluetoothd
> will handle them just as well.
>
> Good luck!
>
> Best,
> Josselin Poiret

Hello Josselin,

I should have been more clear with my last message. Indeed I would be
able to add the additional config values to the service. I haven't done
so because I was told in order to get a service merged into Guix, one
has to provide a "test marionette" (I don't even know what that is since
it's not documented in the manual).

That's what was holding me back. But if that's not the case I'll gladly
submit a patch in the upcoming days.

-- 
Best regards / Mit freundlichen Grüßen,
Demis Balbach

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

  reply	other threads:[~2021-12-11 17:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 12:35 bluetooth-service: addition config vaules Demis Balbach
2021-12-11 13:57 ` Josselin Poiret
2021-12-11 17:02   ` Demis Balbach [this message]
2021-12-13 19:38   ` Demis Balbach
2021-12-17 13:33     ` Demis Balbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r2jt6q1.fsf@minikn.xyz \
    --to=db@minikn.xyz \
    --cc=dev@jpoiret.xyz \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).