Re: 03/06: style: Add support for "newline forms".

Re: 03/06: style: Add support for "newline forms".

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi Ludo'!

Sigh.  Sorry.  I know what this will sound like.  :-)

guix-commits@gnu.org 写道：
> +   ('base32 '(sha256 origin))

I know this is your style, but I would *really* prefer this to be:

> +   ('source '(package))

instead.

I know!  But wait!  I think that's defensible: for the same reason 
that we add a newline after arguments, these few extra columns 
give an (IMO) surprising amount of breathing room down the road.

Well, anyway, I'll shut up,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

Re: 03/06: style: Add support for "newline forms".

[Ludovic Courtès]

Hi!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> guix-commits@gnu.org 写道：
>> +   ('base32 '(sha256 origin))
>
> I know this is your style, but I would *really* prefer this to be:
>
>> +   ('source '(package))
>
> instead.
>
> I know!  But wait!  I think that's defensible: for the same reason
> that we add a newline after arguments, these few extra columns 
> give an (IMO) surprising amount of breathing room down the road.

No strong opinion here, you may well be representing the majority, and
I’m fine with the change you propose.  :-)

There’s a couple of tests that will need to be adjusted but it should be
alright.

(Maybe a few months from now we’ll have additional switches, like
‘-x civodul’, ‘-x nckx’, who knows?  :-))

Ludo’.