From: "Ludovic Courtès" <ludo@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org
Subject: Re: 03/06: style: Add support for "newline forms".
Date: Tue, 18 Jan 2022 15:56:05 +0100 [thread overview]
Message-ID: <871r15gkje.fsf@gnu.org> (raw)
In-Reply-To: <87iluqqksz.fsf@nckx> (Tobias Geerinckx-Rice's message of "Tue, 11 Jan 2022 17:33:36 +0100")
Hi!
Tobias Geerinckx-Rice <me@tobias.gr> skribis:
> guix-commits@gnu.org 写道:
>> + ('base32 '(sha256 origin))
>
> I know this is your style, but I would *really* prefer this to be:
>
>> + ('source '(package))
>
> instead.
>
> I know! But wait! I think that's defensible: for the same reason
> that we add a newline after arguments, these few extra columns
> give an (IMO) surprising amount of breathing room down the road.
No strong opinion here, you may well be representing the majority, and
I’m fine with the change you propose. :-)
There’s a couple of tests that will need to be adjusted but it should be
alright.
(Maybe a few months from now we’ll have additional switches, like
‘-x civodul’, ‘-x nckx’, who knows? :-))
Ludo’.
prev parent reply other threads:[~2022-01-18 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164182331757.10378.13440878503433702005@vcs2.savannah.gnu.org>
[not found] ` <20220110140158.960BFC0DA1D@vcs2.savannah.gnu.org>
2022-01-11 16:33 ` 03/06: style: Add support for "newline forms" Tobias Geerinckx-Rice
2022-01-18 14:56 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r15gkje.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).