From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oDcQGAuM/2NbUAEAbAwnHQ (envelope-from ) for ; Wed, 01 Mar 2023 18:31:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gCoaGAuM/2OHVgAAauVa8A (envelope-from ) for ; Wed, 01 Mar 2023 18:31:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F146838085 for ; Wed, 1 Mar 2023 18:31:54 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXQIV-0003yy-Hw; Wed, 01 Mar 2023 12:31:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXQIU-0003xy-6w for guix-devel@gnu.org; Wed, 01 Mar 2023 12:31:22 -0500 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXQIS-0005TG-6a; Wed, 01 Mar 2023 12:31:21 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:3a91:a0a4:ecee:f157]) by mira.cbaines.net (Postfix) with ESMTPSA id 2BEF816C38; Wed, 1 Mar 2023 17:31:17 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id b6931dec; Wed, 1 Mar 2023 17:31:16 +0000 (UTC) References: <878rgga1qv.fsf@inria.fr> User-agent: mu4e 1.8.13; emacs 28.2 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: 61894@debbugs.gnu.org, guix-maintainers@gnu.org, guix-devel@gnu.org Subject: Re: [bug#61894] [PATCH RFC] Team approval for patches Date: Wed, 01 Mar 2023 17:15:26 +0000 In-reply-to: <878rgga1qv.fsf@inria.fr> Message-ID: <871qm8wf8e.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677691915; a=rsa-sha256; cv=none; b=EOPfTwYqAtiot3rxkQVIq/BIRkleoLO333VFMfkeNAKXthhPN4CpZRFmT3x1gGUuThJeH8 TvaT6WNllLCyL7rhNoj42WcfQhpV4RWIiSBPl6mAjg4aQgWL97tmfE9W00TLR7iwNde+oZ 86VLpl7Eh4PphGwVVRzyJPpXM0kco32F6PcCtbnsrNTKrBZ2oMYz3ATuuOaZhldTeXBIRe dSqKgVRMdmmvxDlPK+/esxrsgckbwH392UN9wB9UDanhhnMG1d2y3MgpeWQztgjKA+60f1 6dTPduSpYKTqco1W/ekGkIl6eJbz7g+ohOI0l+uZDrGvEhm21yNdu+z6wsYf8g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677691915; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=NJI1Aa/8yzOfR+kTSxLZZMvrADGLFKMG5RZymzdffqU=; b=Clsh0rgfc+J2D9/O5QkVDNWRedoNvtyQTrUDVpI1ElEotsjjPcTioKrBk9urx5InIoMatR HsNw84d0YwDgJoC3osxoPccLXS6XpTGeFsrblsyobob9q0pukWmmXnTL2WtUWkayTDz0cb Z9fLOHxHruBeRdbbhYUWKMBYseR6OxGkIoARkqYPY0iSPIp99ASyRFZ1m9onBAYR0lWA3x Q3IlrGToC2HxgcV+/vSudGf2zkVR82xN+GaWAYqhPZaErbVpJZwY7GF6lthw/SJvr3pZEU Fb1ew/CYWYmgtrRNPatkx6HhMNf2N9WVfo9bzfmxHNKQZWDqRKrcMNC62gNsFQ== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -3.59 X-Spam-Score: -3.59 X-Migadu-Queue-Id: F146838085 Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: 5kvCEQDPmm9c --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Currently teams are described mostly as pools of people who can mentor > contributors in a particular area and who can review patches in that > area. My proposal is to give teams formal approval power over changes > to code in their area. > > This is sorta happening already, but informally: if a non-committer > sends a patch, someone from the team eventually =E2=80=9Capproves=E2=80= =9D it by pushing > it. Within a team, the situation is different: people usually discuss > changes, and the submitter (also committer) eventually pushes them; > sometimes, the submitter pushes changes without getting approval (or > feedback) from others on the team. > > With the proposed policy, members of a team would also have to review > and approve each other=E2=80=99s work. Formal approval means getting an > explicit =E2=80=9CLGTM=E2=80=9D (or similar) from at least one other team= member. > > This is similar to the review thresholds found on GitLab & co., where > project admins can specify a minimum number of approvals required before > a change is marked as ready. I think it avoids the unavoidable > misunderstandings that can arise in a growing group and help pacify > day-to-day collaboration. I guess I'm still a team sceptic, I think the idea is interesting and I have added myself as a member of some teams. But the main impact on me so far is that I've just been getting some unwanted personal email, messages that previously wouldn't have landed in my inbox have been doing so. Regarding this change specifically though, I'm unclear how it would impact the things I push for others. I pushed some patches today, would this mean that I'd have to look at what team/teams are involved (according to /etc/teams.scm.in) for each commit/series, and then either continue if I'm a member of that team, or skip it if I'm not? If I'm going to not be pushing stuff I would have previously pushed because I'm not in the relevant teams, maybe I should just add myself to every team? I guess this is not a serious question, but I'm more making the point that if teams become a formal part of patch review, then some formalities over membership of a team is probably a prerequsite. As a point of clarification, if a patch or series touches files that fall within the scope of several teams, am I correct in saying that this change would require approval from all teams? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmP/i+JfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xfggg//Q5dqVs810PhFfWu42fgfn5ddY7DknJdT FYamJun/Fsb/NFYyibTIP2iWnkdYTRLZpKye5LE3o4JDGJw8nQSrFe45Y2PmRPBI lOmZlTXLuTY4ZblXfesqnFf4XTA6oaD7cVHV0LuPoPtZ+J+ghgiQTu2w9uC0roup 8DRBjCfwl2/qCFN8zvLcgIVHWeOxTii5SZrcs7m/nP2ZTAYpTjuhcNEjlv15PNBF QDTzvHMoESjUeqlEIFB9Q0vksyCMY+BcCZxqnOJ3+xHVfWlXyv1e5wPrjZbWX3+2 5/KFYYcpeCZQhI+9+2p4ptuFdfFmoJS/oPa2Nyyfq/1rExbR3aCnfkbMlltyRcPO z88e7CtG94WeqXMkChprh7tklQlQWBNkYRgVDDxdca8B5fmsnierXUDudG32q72D FPSgqNfT068EnptHVpzVbhhL6+0j/oj7wH8i4sqH2VrGWS+0iVbbRPUWXlqKM5nT LpuYsuima/YwNN7ZsFvnoC78D842SdvQWWvBrHQyCNqIqNAbjIldl8HAcTGvAMUU 9ynAxjZDM/CxmGDsEaP0dcHIgj6iNthAXaX4HWVrKHCtHN/2+HABJeocvMATMfk6 eyw8F/PzY2h2aY8FxSvBF4Zx5hFAULeIihLo0pBc4fuEiYJDI0UPsoVYsplL2wjP VcsLfBk3E7U= =2xHO -----END PGP SIGNATURE----- --=-=-=--