From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eKRvGZpItF+jMQAA0tVLHw (envelope-from ) for ; Tue, 17 Nov 2020 22:03:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gF1iFZpItF8gDAAAbx9fmQ (envelope-from ) for ; Tue, 17 Nov 2020 22:03:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DADF7940237 for ; Tue, 17 Nov 2020 22:03:05 +0000 (UTC) Received: from localhost ([::1]:33940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf944-0003kd-Lo for larch@yhetil.org; Tue, 17 Nov 2020 17:03:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf93i-0003hO-7v for guix-devel@gnu.org; Tue, 17 Nov 2020 17:02:43 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:37048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kf93X-0001TO-Cd for guix-devel@gnu.org; Tue, 17 Nov 2020 17:02:40 -0500 Received: by mail-wr1-x42e.google.com with SMTP id b6so24987522wrt.4 for ; Tue, 17 Nov 2020 14:02:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=GmocmoM/djqOaAM6d5sC6NNwIgMfVFiroAMIMXvDL8c=; b=bMOCQmlw+8ugcwCMp4lp5UqfQmRm85jnIrnCGqXz90UKps7yBs9o7cH/7HsVaol7fy LJWDBft4YB03eeOUQq81NGAoPrx2k/ytWnJpGFElCeDSiXhwopOz9Y6XGN6k6YLL45tE 5lMP36bzUdiqi9GLqrkJ4bQ+l4opGisd4JlzAg9Tg6IzNegyXQt6t7qCHJAC83s4f22A bol3sBVfE6a2lvxUdNW5nhYRPgdqGqoA5rJZDR4DgDfFMIFxeI7B6jevxKJCLmqc8CU7 KXjTd/9mWZdRNrgEUtm1mkJSWGH3vt6lWBqsHimCoj9bO9n89+H2nPG8LCoMehlT3Udf 3xnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=GmocmoM/djqOaAM6d5sC6NNwIgMfVFiroAMIMXvDL8c=; b=rwI086MTHzxNjKJR5Qtjq7ujErVEJSzGvS5+BKwnhOzfu6cWOJzcyaQOqLXrOyCOfC R44i+1DStS9QIDnqJg8CXIAIYF7B9KfJwo0c1nX6XqMGz2qVA9yG4JTjR6FEz4jed3aw FjtjrOurYvwhG1xH/JCU13Vwh+LBpfQ6GQSFG8FG4fA7jsnsnslI+6i4qyQ34BazGzm4 SwMXYk2qQUcqESdLMCsC8VbXhX+Mebrs9j4bbbGwKIdyIoZ8LD4cw283iFs5LFeo2zyn FOjO7yxI9Ch3THv3mQRhJeb95hE6murmKUADDmp2ajz30Lwj0M2e1SHXs7sJZrkXUmlV kbXg== X-Gm-Message-State: AOAM532PpLI161QGOdwIkJ0FPlTuBODOuvSWIgc45w3wGxhz5Y30By2f M6xBi3BKCpi5b5LDRJGeLQzzTxMgd0aClA== X-Google-Smtp-Source: ABdhPJxX5TRfogrdEYGuMr6/htVQtDmsRyK9u5Na1HIVQSsyzOazpEKjTYJC/9s3Av+Y7UgSwhP76g== X-Received: by 2002:a5d:444c:: with SMTP id x12mr1641178wrr.6.1605650549040; Tue, 17 Nov 2020 14:02:29 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id c187sm138233wmd.23.2020.11.17.14.02.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 14:02:28 -0800 (PST) From: zimoun To: Christopher Baines Subject: Fix incorrect date and commit in Data Service In-Reply-To: <863617oe1h.fsf@gmail.com> References: <868scbvalo.fsf@gmail.com> <87d01m3475.fsf@ambrevar.xyz> <87a6wg7wto.fsf@gnu.org> <87k0ulm78x.fsf@cbaines.net> <86a6vhqcc3.fsf@gmail.com> <87blfxm39q.fsf@cbaines.net> <86v9e5ovjp.fsf@gmail.com> <875z65m0of.fsf@cbaines.net> <86o8jxorky.fsf@gmail.com> <863617oe1h.fsf@gmail.com> Date: Tue, 17 Nov 2020 22:57:05 +0100 Message-ID: <86zh3fmytq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=bMOCQmlw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: 5NNwK6q1HvLX Hi again, On Tue, 17 Nov 2020 at 22:43, zimoun wrote: > Well, the Data Service should filter out the messages only containing > the header X-Git-Rev (commit hash) and use the date (Date) of the > message, which is, IMHO, the most accurate way to do. Instead of rely > on the date of message containing such headers: > > X-Git-Oldrev: 3b026eb3b1dd92c653d1a640b1280b96cfea3084 > X-Git-Newrev: b5e51a06de08f446a07f678ff806cd71a355f7 > > which can miss the correct commit introducing a change of derivation. The file data-service/branch-updated-emails.scm contains: (x-git-newrev (assq-ref headers 'x-git-newrev))) which is the issue. Instead, it should be (x-git-rev (assq-ref headers 'x-git-rev))) but maybe some filtering should be applied. Well, to be continued=E2=80=A6 All the best, simon