unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Thursday 18th: ‘core-updates-frozen’ sprint!
Date: Wed, 24 Nov 2021 12:07:50 +0100	[thread overview]
Message-ID: <86zgptu7zt.fsf@gmail.com> (raw)
In-Reply-To: <87fsroaqzv.fsf@gmail.com>

Hi,

On Mon, 22 Nov 2021 at 15:13, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> 2. Disable the problematic tests.  You may need to disable a whole test suite of
> similarly faulted tests, if they all behave the same.

I am becoming crazy…  For instance this test randomly* fails:

    @test mul!(C, vf, transpose(vf), 2, 3) == 2vf*vf' .+ 3C0

<https://github.com/JuliaLang/julia/blob/v1.6.3/stdlib/LinearAlgebra/test/matmul.jl#L155>

Therefore, I add,

--8<---------------cut here---------------start------------->8---
            (substitute* "stdlib/LinearAlgebra/test/matmul.jl" 
              (("@test mul\\!\\(C, vf, transpose\\(vf\\), 2, 3\\) == 2vf\\*vf' \\.+ 3C0") 
               "@test_broken @test mul!(C, vf, transpose(vf), 2, 3) == 2vf*vf' .+ 3C0")
            (substitute* "test/math.jl" 
              (("@test isinf\\(log1p\\(-one\\(T\\)\\)\\)")
               "@test_broken isinf(log1p(-one(T)))"))))
--8<---------------cut here---------------end--------------->8---

So far, so good.  Then I get:

--8<---------------cut here---------------start------------->8---
Error During Test at /tmp/guix-build-julia-1.6.3.drv-0/julia-1.6.3/test/math.jl:278
 Unexpected Pass     
Expression: isinf(log1p(-(one(T))))
 Got correct result, please change to @test if no longer broken.
--8<---------------cut here---------------end--------------->8---

and thus the build is reported as failed.  Argh!!  Ok, because these 2
tests are random, I replace the snippet above by:

--8<---------------cut here---------------start------------->8---
            (substitute* "stdlib/LinearAlgebra/test/matmul.jl" 
              (("@test mul\\!\\(C, vf, transpose\\(vf\\), 2, 3\\) == 2vf\\*vf' \\.+ 3C0") 
               "")
            (substitute* "test/math.jl" 
              (("@test isinf\\(log1p\\(-one\\(T\\)\\)\\)")
               ""))))
--8<---------------cut here---------------end--------------->8---

And now, something magical happens, I get this error with parenthesis:

--8<---------------cut here---------------start------------->8---
Test Failed at /tmp/guix-build-julia-1.6.3.drv-0/julia-1.6.3/usr/share/julia/stdlib/v1.6/LinearAlgebra/test/matmul.jl:155
Expression: mul!(C, vf, transpose(vf), 2, 3) == (2vf) * vf' .+ 3C0
--8<---------------cut here---------------end--------------->8---

What?!  And AFAIU, it is not in the test suite.

Do I miss something with ’substitute*’?


Cheers,
simon

*randomly: because I do not know why, nothing is random with
 computer. ;-)

PS: Note that current Julia master contains this test:

        @test mul!(C, vf, transpose(vf), 2, 3) ≈ 2vf*vf' .+ 3C0

https://github.com/JuliaLang/julia/blob/master/stdlib/LinearAlgebra/test/matmul.jl#L155

I am trying to ’substitute*’ with that.  Then I give up for now.


  reply	other threads:[~2021-11-24 11:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 11:46 Thursday 18th: ‘core-updates-frozen’ sprint! Ludovic Courtès
2021-11-17 12:06 ` Ricardo Wurmus
2021-11-19 15:01 ` Ludovic Courtès
2021-11-19 23:43   ` Ricardo Wurmus
2021-11-22 13:19     ` Ludovic Courtès
2021-11-22 13:36       ` zimoun
2021-11-22 20:13         ` Maxim Cournoyer
2021-11-24 11:07           ` zimoun [this message]
2021-11-25  2:13           ` ‘core-updates-frozen’: julia status zimoun
2021-11-25 23:49             ` ‘core-updates-frozen’: julia status update zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zgptu7zt.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).