unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: Timothy Sample <samplet@ngyro.com>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: disarchive: disassemble then assemble tarball
Date: Mon, 03 Apr 2023 23:08:47 +0200	[thread overview]
Message-ID: <86v8icy8ps.fsf@gmail.com> (raw)
In-Reply-To: <871ql0zpka.fsf@ngyro.com>

Hi,

On Mon, 03 Apr 2023 at 14:19, Timothy Sample <samplet@ngyro.com> wrote:

> The ‘assemble-tarball’ procedure assumes (without checking) that it has
> access to a copy of its input in the “workspace” directory.  Normally,
> it would be called from the generic ‘assemble’ procedure, which ensures
> this (and also checks the output).  It probably just wrote all the
> tarball headers without the file contents, producing a corrupt tarball.
> Indeed, if you set up logging (using ‘%disarchive-log-port’) it prints a
> bunch of “Ignoring irregular file” warnings.

Ok, but I was expecting a kind of identity when composing
’disassemble-tarball’ and ’assemble-tarball’.  And even, that the
identity properties of assembling some disassembling would be some
tests. :-)


>> Well, I am not sure to understand why the name “my-gnu”.
>
> It’s just ‘(basename "my-gnu.tar" ".tar")’.  The names are designed to
> aid a human while debugging.  To my knowledge, Disarchive doesn’t use
> them for anything.  You can use set the name by passing “--name” to the
> ‘disassemble’ subcommand.

Thanks for explaining.


> In other words, it’s your old nemesis:
>
>   https://lists.gnu.org/archive/html/guix-devel/2023-03/msg00063.html
>
> :)  (I tease only because it’s confused me many times too!)

Arf, probably because the behaviour appears to me unexpected. :-)

Well, maybe some convention with trailing / would be helpful, as with
’rsync’.


Cheers,
simon


      reply	other threads:[~2023-04-03 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 14:58 disarchive: disassemble then assemble tarball Simon Tournier
2023-04-03 20:19 ` Timothy Sample
2023-04-03 21:08   ` Simon Tournier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86v8icy8ps.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=samplet@ngyro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).