From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sI5DI873nmIKNQEAbAwnHQ (envelope-from ) for ; Tue, 07 Jun 2022 09:01:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yMgPI873nmLVUwAAauVa8A (envelope-from ) for ; Tue, 07 Jun 2022 09:01:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 520E825058 for ; Tue, 7 Jun 2022 09:01:34 +0200 (CEST) Received: from localhost ([::1]:35660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyTDZ-0000W3-2c for larch@yhetil.org; Tue, 07 Jun 2022 03:01:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44140) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyT6d-0005VI-7H for guix-devel@gnu.org; Tue, 07 Jun 2022 02:54:23 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:38440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyT6a-0004yg-0R; Tue, 07 Jun 2022 02:54:22 -0400 Received: by mail-wr1-x42c.google.com with SMTP id q7so22718598wrg.5; Mon, 06 Jun 2022 23:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=/Nt6XhWmDdyYcDo13ckiOUwSaqgJ9J/Q7zmBEKWJO+k=; b=B7oOoet5NwoXHHZz7g/ciNE6QnIeL8nDa7BXUwZCcxN42fKGAkaBg8PZHN2KOFmoEq wcBx71X32lHwUW56XdjgVAn/MV8Mlxconvmm7JBvWX8mQ8eFxW/6wL77ANxbfHRcvvCs GkVYxU7Ned3HOm62AkGq4k02m135tgBgR5IaNf0n2vNG6IbmXQD6vFqDIidWAhmaBzmf 24JnarqbEGGVJeeM1JnE5MZFcNg4ZNxNopWX8StexPzB6Orm16cdFUkoizaD3tI+NyQT sPZPqF2NyW861IYiAyBGhdFs4TLAeQIP0/pz8T0SVlwraoYRTMtMMBl3d4glyA4CtQq+ bV9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=/Nt6XhWmDdyYcDo13ckiOUwSaqgJ9J/Q7zmBEKWJO+k=; b=VOPvMU2CR9jY654zI7waU4KNpAzA65t/Pkf1oGwAsAGV42JJJy12nWVKL6Ncr+cKZ0 bX68I7D/KnSUZcsJFfTF706eCfuXtVQpAIoNDkxSbORFl7UH410fkIJpSjydWsUcAUTO Wr6bNXrrthW+3bAaz2K9xA7acQFT2jHx7YqN05DDnvDnmF9nf0WzgCjU9YYq3ICkh0P6 3L3VG8AaZnBoJxQ8eWX+RxCIzRYhuZcIaeQMT9c1aynCmdDU27DEwAooBOtumsnkpsPR OhFUCxYJGO4o3lr2Or1hhjpEvuSYH4bqbyonA69rX1Gtj1dHcJE5RGto3ynyr4RYAxI8 Zubw== X-Gm-Message-State: AOAM530pOg5TS9V9+fYfxfiJbaO86Rf84xTqXkvaHrkIHHF2yc6UVhYX ckOYtlfbeYVYVHCuU/e3TqhTMhSb1iQ= X-Google-Smtp-Source: ABdhPJyF8Br/ip7eDpkP26QVWLliOnA6g5LwOyQgIoe4VRzJP++ug5UXNcNXut7/WtQdlJnCoP2ksA== X-Received: by 2002:a5d:4112:0:b0:216:1abb:f731 with SMTP id l18-20020a5d4112000000b002161abbf731mr16610729wrp.618.1654584856779; Mon, 06 Jun 2022 23:54:16 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id h1-20020a056000000100b0020c5253d8casm17116688wrx.22.2022.06.06.23.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 23:54:16 -0700 (PDT) From: zimoun To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Arun Isaac Cc: Guix Devel , GNU Guix maintainers Subject: Re: On commit access, patch review, and remaining healthy In-Reply-To: <87fskha2nr.fsf@gnu.org> References: <87ee07m77w.fsf@gnu.org> <877d5um1oe.fsf@systemreboot.net> <87fskha2nr.fsf@gnu.org> Date: Tue, 07 Jun 2022 08:44:19 +0200 Message-ID: <86tu8xdlbw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654585294; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=/Nt6XhWmDdyYcDo13ckiOUwSaqgJ9J/Q7zmBEKWJO+k=; b=hcfu+pkzWdelUDG8Kp9/0jAr1Y7GHGn6mlNdve6Ca9r5kYYbaNUgL2Viqu1M2R2tvfIrSS AzpHm6mP0JhXYkcsjX+++eNavoIgK0awumbKLkfJrWRh+uLsc2uEXAeoyvy0W/Ez6HZHYA uTmZ4Mz3Wkfrrg4fMt3nJu1WYoUbg2ajzhttCpIcTihlHKw7J+L5xZAsCYI7U8Py95rNw9 ryv+Bq8W8fQT0u32Yhb+gMtnWZQpd8GxxnBqz0wHfHBUZ0ATuNLP0lS6eCF1mW9DrUb2C8 N6yPepLmFHR3dt9f/vN+MRkkhCRkFktMvva1/yQKS/RjuH/v002TEOyrba80Iw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654585294; a=rsa-sha256; cv=none; b=l32FCyDc07rOuBARq1lNEeW96q1c7l7UnV6MODGCDvNmyah5V4x/3nzI+1UjgFGBTAqTNs UqTIVsq2p4jgvIc4cXZ26/Btb3p8Y/av73uX8IECqvod5DVu1BohCkEmBFt7JvhDQrXWxb el3OaeSXFxgoLXVBVlQgc/728G+EZlFsXHPl1uZNIHHkcp2PSYoL48IPQ/G8Nw6EgUVG4W TZlF2M4iY78DU27qwuw/wRbDoVW4PKbMxt7eSwbCDTaKzoYvEbL1VHcm6FwOBtEHFWfUJf yzphcp8N+29i8zvBryKVI1J7TD9Q8Q9qzsFGcSEOJm80VhzA1N3GrVWZYI+sYA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B7oOoet5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.31 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B7oOoet5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 520E825058 X-Spam-Score: -5.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: AQyNWschdDEJ Hi, On Mon, 06 Jun 2022 at 23:43, Ludovic Court=C3=A8s wrote: > I can think of two ways to reassure committers: > > 1. By having clear reviewer check lists (you=E2=80=99d do that if you t= ick all > the boxes, you=E2=80=99re fine); As pointed earlier by Arun in =C2=ABPublic guix offload server=C2=BB [1], t= his check list would imply some rebuilds and it can be difficult depending on the resource at hand by the committer who reviews. 1: https://yhetil.org/guix/878rynh0yq.fsf@systemreboot.net > 2. By improving automation=E2=80=94nothing new here: if there was a tic= k that > says =E2=80=9Capplies without merge conflicts=E2=80=9D and another o= ne that read > =E2=80=9Cbuilds fine=E2=80=9D, anyone could lightheartedly hit the = =E2=80=9Cmerge=E2=80=9D button. >From my understanding, one of the issue is where the committers push vs where the users pull. Basically, the push happen on master and the changes are directly available to the users. On one hand, it is nice because the things are delivered faster. On the other hand, a tiny change can break many workflows =E2=80=93 it is or could be a reason for refraining pushing. More eyes who review help, for sure. But it is not straightforward as we are often discussing. :-) More tools can also help, but AFAIK, nothing is fully ready right now. What remain is: not push to the production branch. :-) Maybe, we could push to a branch =E2=80=9Cunstable=E2=80=9D **automatically** merged every = week to the branch =E2=80=9Cstable=E2=80=9D and by default user pull =E2=80=9Cstable=E2= =80=9D. One week let the time to build by the CI, check everything is fine and fix otherwise. It reduces a bit the pressure on the committers, IMHO. We =E2=80=93 from core developers to user just wanting the things done =E2= =80=93 are all pulling the same branch. This branch cannot satisfy in the same time all the constraints; is the current push/pull branch model satisfying the best optimum with the resource and tools at hand? Cheers, simon