unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Process for reviewing patches as someone without commit access
@ 2023-09-06 15:55 Christopher Baines
  2023-09-06 18:17 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Christopher Baines @ 2023-09-06 15:55 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

Hey!

I've been reviewing the list of ideas on and around QA ([1]) recently,
and got thinking again about how to support people without commit access
reviewing patches. Obviously you don't need commit access to review
patches, but where I think we need some process is how to expedite
someone with commit access taking a look at the patches that have been
reviewed, and merging them if appropriate.

1: https://qa.guix.gnu.org/README

Maybe we can use debbugs tags for this? It looks like this has already
been done in the past, I found some issues tagged with the usertag
"reviewed" for example [1]. Some were also tagged with
"reviewed-looks-good". I guess my primary concern is to have a tag (or
combination of tags) which indicate that a committer should have a look
at the issue as it's been reviewed by someone and should be ready to
merge. I don't really use debbugs much, but does anyone have any
opinions on appropriate tags?

1: https://debbugs.gnu.org/cgi-bin/pkgreport.cgi?tag=reviewed&users=guix

Once we know what tags to use, I can have the QA frontpage do something
similar to the "Mark as moreinfo" links, so it's easy to just click a
button then send the email to change the state of a issue.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-10-04 15:51 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-06 15:55 Process for reviewing patches as someone without commit access Christopher Baines
2023-09-06 18:17 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-06 18:19   ` Christopher Baines
2023-09-06 19:01     ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-06 23:37       ` Simon Tournier
2023-09-06 23:59 ` Simon Tournier
2023-09-07  2:47   ` Maxim Cournoyer
2023-09-07  9:55     ` Simon Tournier
2023-09-07 16:19     ` Vagrant Cascadian
2023-09-07 19:05       ` Simon Tournier
2023-09-27 11:58 ` Christopher Baines
2023-10-04 15:46   ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).