unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* emacs-build-system installs too many files
@ 2017-04-14  9:03 Arun Isaac
  2017-04-14 17:16 ` Alex Kost
  0 siblings, 1 reply; 7+ messages in thread
From: Arun Isaac @ 2017-04-14  9:03 UTC (permalink / raw)
  To: guix-devel


The install phase of the emacs-build-system simply copies all files to
the output directory. This ends up copying many unnecessary files such
as README, Makefile, tests, hidden files such as .gitignore,
.travis.yml, etc. MELPA package recipes, on the other hand, copy only a
subset of the files. This is provided by the :files property in their
recipe format (https://github.com/melpa/melpa#recipe-format). Quoting
from their github page:

#+BEGIN_QUOTE

:files is an optional property specifying the elisp and info files used
to build the package. Please do not override this if the default value
(below) is adequate, which it should usually be:

  ("*.el" "*.el.in" "dir"
   "*.info" "*.texi" "*.texinfo"
   "doc/dir" "doc/*.info" "doc/*.texi" "doc/*.texinfo"
   (:exclude ".dir-locals.el" "test.el" "tests.el" "*-test.el" "*-tests.el"))

This option is necessary when there are multiple packages in the
repository and thus the package should only be built from a subset of
.el files. For example, elisp test files should not normally be
packaged. Any file specified at any path in the repository is copied to
the root of the package.

...

Note that elisp in subdirectories is never included by default, so you
might find it convenient to separate auxiliiary files such as tests into
subdirectories to keep packaging simple.

#+END_QUOTE

I suggest we modify the emacs-build-system to include a #:files argument
similar to MELPA's :files property. If others are fine with this, I will
start working on a patch.

Regards,
Arun Isaac.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: emacs-build-system installs too many files
  2017-04-14  9:03 emacs-build-system installs too many files Arun Isaac
@ 2017-04-14 17:16 ` Alex Kost
  2017-04-19  7:51   ` Arun Isaac
                     ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Alex Kost @ 2017-04-14 17:16 UTC (permalink / raw)
  To: Arun Isaac; +Cc: guix-devel

Arun Isaac (2017-04-14 14:33 +0530) wrote:

> The install phase of the emacs-build-system simply copies all files to
> the output directory. This ends up copying many unnecessary files such
> as README, Makefile, tests, hidden files such as .gitignore,
> .travis.yml, etc. MELPA package recipes, on the other hand, copy only a
> subset of the files. This is provided by the :files property in their
> recipe format (https://github.com/melpa/melpa#recipe-format). Quoting
> from their github page:
[...]
> I suggest we modify the emacs-build-system to include a #:files argument
> similar to MELPA's :files property. If others are fine with this, I will
> start working on a patch.

I totally agree!  I suggested to remove non-"el[c]" files when Federico
introduced the emacs-build-system.  I mentioned it here:

  http://lists.gnu.org/archive/html/guix-devel/2015-07/msg00301.html

and a couple of times later :-) But I didn't do anything to implement
this idea, and I think it would be really great if you will give it a
try.  Thank you!

-- 
Alex

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: emacs-build-system installs too many files
  2017-04-14 17:16 ` Alex Kost
@ 2017-04-19  7:51   ` Arun Isaac
  2017-04-19  7:51   ` Arun Isaac
       [not found]   ` <cu7mvbcq1gy.fsf@systemreboot.net>
  2 siblings, 0 replies; 7+ messages in thread
From: Arun Isaac @ 2017-04-19  7:51 UTC (permalink / raw)
  To: Alex Kost; +Cc: guix-devel


> I think it would be really great if you will give it a try.

I have a work in progress patch implementing the ideas discussed.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: emacs-build-system installs too many files
  2017-04-14 17:16 ` Alex Kost
  2017-04-19  7:51   ` Arun Isaac
@ 2017-04-19  7:51   ` Arun Isaac
       [not found]   ` <cu7mvbcq1gy.fsf@systemreboot.net>
  2 siblings, 0 replies; 7+ messages in thread
From: Arun Isaac @ 2017-04-19  7:51 UTC (permalink / raw)
  To: guix-devel


> I think it would be really great if you will give it a try.

I have a work in progress patch implementing the ideas discussed.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: emacs-build-system installs too many files
       [not found]   ` <cu7mvbcq1gy.fsf@systemreboot.net>
@ 2017-05-14 13:45     ` Arun Isaac
  2017-05-15 17:19       ` myglc2
  0 siblings, 1 reply; 7+ messages in thread
From: Arun Isaac @ 2017-05-14 13:45 UTC (permalink / raw)
  To: guix-devel


> I have a work in progress patch implementing the ideas discussed.
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559

Alex Kost and I have finalized this patch, more or less. It would be
good if someone else could review it, and provide feedback so that we
can push it and close the bug report.

Thanks!

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: emacs-build-system installs too many files
  2017-05-14 13:45     ` Arun Isaac
@ 2017-05-15 17:19       ` myglc2
  2017-05-15 18:46         ` Arun Isaac
  0 siblings, 1 reply; 7+ messages in thread
From: myglc2 @ 2017-05-15 17:19 UTC (permalink / raw)
  To: Arun Isaac; +Cc: guix-devel

On 05/14/2017 at 19:15 Arun Isaac writes:

>> I have a work in progress patch implementing the ideas discussed.
>>
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26559
>
> Alex Kost and I have finalized this patch, more or less. It would be
> good if someone else could review it, and provide feedback so that we
> can push it and close the bug report.
>
> Thanks!

Hi Arun,

I'm not qualified to review the code, but, FWIW, I used these patches to
install emacs packages I use and don't use ... and I encountered no
difficulty. ;-)

- George

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: emacs-build-system installs too many files
  2017-05-15 17:19       ` myglc2
@ 2017-05-15 18:46         ` Arun Isaac
  0 siblings, 0 replies; 7+ messages in thread
From: Arun Isaac @ 2017-05-15 18:46 UTC (permalink / raw)
  To: myglc2; +Cc: guix-devel


> I used these patches to install emacs packages I use and don't use
> ... and I encountered no difficulty. ;-)

Thanks for the feedback! :-)

Once one of the Guix maintainers gives me the green light, I'll push...

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-05-15 18:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-14  9:03 emacs-build-system installs too many files Arun Isaac
2017-04-14 17:16 ` Alex Kost
2017-04-19  7:51   ` Arun Isaac
2017-04-19  7:51   ` Arun Isaac
     [not found]   ` <cu7mvbcq1gy.fsf@systemreboot.net>
2017-05-14 13:45     ` Arun Isaac
2017-05-15 17:19       ` myglc2
2017-05-15 18:46         ` Arun Isaac

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).