From mboxrd@z Thu Jan 1 00:00:00 1970 From: myglc2 Subject: Re: [PATCH] Re: The usability of Guix configurations Date: Tue, 07 Nov 2017 17:56:39 -0500 Message-ID: <86o9odr93s.fsf@gmail.com> References: <868tfjw4is.fsf@gmail.com> <20171106221621.GA2534@jasmine.lan> <86o9oex34v.fsf@gmail.com> <779b1b6f2043e03a2f911981142e7740@lepiller.eu> <777f3534955ec61a520ff5f9b7054673@lepiller.eu> <86tvy6tbz5.fsf@gmail.com> <86efpat6z6.fsf@gmail.com> <867ev2t13i.fsf@gmail.com> <20171107222658.55c2bfda@lepiller.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCCnW-0005k7-FT for guix-devel@gnu.org; Tue, 07 Nov 2017 17:56:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCCnS-0004Nd-CF for guix-devel@gnu.org; Tue, 07 Nov 2017 17:56:46 -0500 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:44783) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCCnS-0004NI-7j for guix-devel@gnu.org; Tue, 07 Nov 2017 17:56:42 -0500 Received: by mail-qk0-x22a.google.com with SMTP id v137so1162417qkb.1 for ; Tue, 07 Nov 2017 14:56:42 -0800 (PST) In-Reply-To: <20171107222658.55c2bfda@lepiller.eu> (Julien Lepiller's message of "Tue, 7 Nov 2017 22:27:14 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Julien Lepiller Cc: guix-devel@gnu.org On 11/07/2017 at 22:27 Julien Lepiller writes: > Le Tue, 07 Nov 2017 13:06:41 -0500, > myglc2 a =C3=A9crit : > >> On 11/07/2017 at 17:25 julien lepiller writes: >>=20 >> > Le 2017-11-07 16:59, myglc2 a =C3=A9crit=C2=A0:=20=20 >> >> On 11/07/2017 at 15:52 julien lepiller writes:=20=20 >> >>> >> >>> Maybe that's too much?=20=20 >> >> >> >> Not for me. Looks great! Just a couple minor suggestions: >> >> >> >> 1) How about narrowing search to locations like this: >> >> >> >> Hint: You may use `guix package --show=3Dfoo | grep location` to >> >> search for foo's location.=20=20 >> > >> > Oh, I didn't know this option, good idea, thanks :D >> >=20=20 >> >> >> >> 2) I think you mean to say "foo" where you say "ssh" in the last >> >> two HINTs=20=20 >> > >> > You're right, though I prefer to use "bar" to show there is no >> > relation between >> > the package name and its module. >> > >> > I added "[PATCH]" to the subject to get others look at this >> > message. I plan to >> > push it in a few days unless it gets more comments. If an >> > experienced schemer >> > could look at that, I'm sure the coding style could be improved a >> > lot ;)=20=20 >>=20 >> Hmm, I think you introduced a bug in your last changes because I now >> get ... >>=20 >> root@g1 ~/con/17# guix system build sys.scm >> guix system: error: failed to load 'sys.scm': >> /root/con/17/sys.scm:79:19: /root/con/17/sys.scm:79:19: In procedure >> module-lookup: Unbound variable: x11-forwarding? >>=20 >> ... on the attached sys.scm >>=20 > > I don't understand the error... When trying to do (service > openssh-service-type (openssh-configuration))), I get > > sys.scm:86:41: sys.scm:86:41: Wrong type to apply: # openssh-configuration> > > and I can't reproduce from the REPL... Why don't we get the same error > with agetty-configuration (removing the openssh service does not make > any error)? > > I was too optimistic I guess :) Dunno. I double checked. I definitely get 'module-lookup: Unbound variable: x11-forwarding?' here with your latest patch. I am happy to test something if that will help. Just to be clear, I tested the patch that you sent immediately before and _it worked great._ Did you diff these two patches? > I was too optimistic I guess :) This is not a problem for because, in my experience, there is usually too little optimism ;) It seems like I broke the thread. Sorry about that. - George