From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MHZ+Jjf09WOaMgEAbAwnHQ (envelope-from ) for ; Wed, 22 Feb 2023 11:53:43 +0100 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CBeOJTf09WNURgEAG6o9tA (envelope-from ) for ; Wed, 22 Feb 2023 11:53:43 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 5A2C62B27B for ; Wed, 22 Feb 2023 11:53:43 +0100 (CET) Authentication-Results: aspmx2.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nlvroIAC; spf=pass (aspmx2.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677063223; a=rsa-sha256; cv=none; b=fUHqTrJeqpRRezrcz0jMOtKCugzdtLYQ5DBOzPFPK757b24+TqBH2DVF970NW0CFohEoVk Ni9o48WTZgsnCHp2CrdH1OS3S4av5MFKqzSQ/SaUSSW40lEcK9qO8SgKzvVGqgcoswl294 UaxeaC+lKUWAmgnzA2uevJmTgGQi5Nx5fbEwoVFEBWLLg3mTKMB90oopflY05aBinHHgf6 +Mt9rasMcQhU5BdONueRj7YVwsAE+W0rvaOqX6XfBTiNm1HV3ju2cDIB7Gdta73Z23MRFa 9VhIkDgRoqyIywgFLt7Dui637NwC6FKdjvY2Zv71i4z+Xb6zXJJv2+H1YZb3kw== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nlvroIAC; spf=pass (aspmx2.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677063223; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mojo5uI4nHjfBM0gKLNts+/PGq8uptT5XP0nH5YCkUE=; b=hrTNyoCmMZsIF+leZItNZxNJSEma0RXS/WeESIP2EhMKxgCbEJUo6HA+si7PYmOKFskFz5 w4kw5zubUoeoJwzPdnvYe/lxI0BpJVFIWkqlIlEbpJN2tW8CqcqvEK3j0ovdVTYime072L jvZxh3NcuLjTTezpq87p9CaVww5CG7OPnnD3n6jIG1TXGckmEBKxDHxGHYZXw1ZerXCqdQ 1yl5tgcneaku/HFtBbwX83AXnYRqQZWvlJVVPBheV71IVNJ/5JoO4/yFyTpvQOMO1g/CZ2 sK+cJ/cTvVxclF8rqORiLZomY0Tou1ySgbiGANsx3Gi7EVeftrsI6Smc14TLYA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUmkG-0007Pe-2i; Wed, 22 Feb 2023 05:53:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUmkE-0007PT-Tq for guix-devel@gnu.org; Wed, 22 Feb 2023 05:53:06 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUmkD-0001AV-Hz for guix-devel@gnu.org; Wed, 22 Feb 2023 05:53:06 -0500 Received: by mail-wr1-x434.google.com with SMTP id r7so7117815wrz.6 for ; Wed, 22 Feb 2023 02:53:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677063184; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=mojo5uI4nHjfBM0gKLNts+/PGq8uptT5XP0nH5YCkUE=; b=nlvroIACxJGV42PHb5a6OH3Mvj0lTFEQYtnR6N+OL3HqtvQVtD5rZLyrodsySwKhGu SsXooDPtYIA46kP6GGPI3GFXGbYDfJ4BKDz+E5MM1PvtJwa6RVV6tCQk++xHRrd3CLaq TeOQKptNa/Vn2KSQdxbvMjC7AHfxjNenVMOInRnE6/Dc+tcBuEFds/XumVjs6wp5pQ5q u5eOYrhm5bzCudnYxTso8i7gM0ZF3BA0LEA6Do37VN0hIBUptefsX4U3HO4B1VzLBr87 7tTQCdfuTdUt44V7Q57VHK2/p4lGoxIr8du8KC7r9iUxhYUazd4+yBkuDFsvltsHwCEX iziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677063184; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mojo5uI4nHjfBM0gKLNts+/PGq8uptT5XP0nH5YCkUE=; b=Y4hdXYKBL7MQ9+8qwvfUDSBQaAb/cKdCEapkLoFj8jfG/fj1v+nJKps3WzQcqpqmle 8ZoG/f6eLWqoI9ovGXd+RexnsRejWsaAxwn3q/74Vhlw5PQKbQko/WyucR8srGl3+j9p am2QzePT22nK3Q/uYdnlbJk21aUFUKpM07Zbn4ZVRKTKoRRWrYuwviSCX0/d7UmJZpSh CVaNj21YlK7ifJItKyb5ebQdFZHOPmDpaxLzcZJBgFzvP4lJZmJJF9wvk0VJJwkUPyfh Jj3YwK2yR0HnfBJjnPn2Ti97YbH9IrUdxkZkOBIWHj2OTbmLe6TQoQ3PXH0yEsIOk4ac YirQ== X-Gm-Message-State: AO0yUKWO8DH8NP1oLWVSkdzMHSCQQ2TYjVjdPtUUvRO7DGYNhACf7ebf meNwrlFi11XkAnI2xYMkhkffuW6TfMU= X-Google-Smtp-Source: AK7set9b/mh9sORzvZ3eaLim/VF9eJJNFaFinkuau3TS29vEYm48aeVSCrQDaLUnA3uqXmFQ37G8Cg== X-Received: by 2002:a5d:60c7:0:b0:2bf:de9c:4595 with SMTP id x7-20020a5d60c7000000b002bfde9c4595mr5755629wrt.5.1677063183772; Wed, 22 Feb 2023 02:53:03 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id h18-20020a5d4312000000b002be0b1e556esm7858750wrq.59.2023.02.22.02.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 02:53:03 -0800 (PST) From: Simon Tournier To: Vagrant Cascadian , Christopher Baines , guix-devel@gnu.org Subject: Re: Thoughts on committers pushing simple changes from other committers? In-Reply-To: <87v8juq29l.fsf@yucca> References: <87y1ordv5p.fsf@cbaines.net> <87v8juq29l.fsf@yucca> Date: Tue, 21 Feb 2023 22:20:12 +0100 Message-ID: <86k00avhpv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 5A2C62B27B X-Spam-Score: -10.38 X-Migadu-Spam-Score: -10.38 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: hRe1g4DVPjwv Hi, On Tue, 21 Feb 2023 at 10:52, Vagrant Cascadian wrote: > There is also no sign like "this has been reviewed by N people" better > than one person authoring it and another person pushing and signing it, > with some Reviewed-by or other relevent tags in the commit. I agree that Reviewed-by would be helpful. Once reviewed, the author or the reviewer could roll the count and re-send the patch (or series), applying the line Reviewed-by. It would reward the reviewer for their work. And it would help the committer work. Cheers, simon