From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2DdGGPaGqGIJpgAAbAwnHQ (envelope-from ) for ; Tue, 14 Jun 2022 15:02:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yP85F/aGqGLGFwEAG6o9tA (envelope-from ) for ; Tue, 14 Jun 2022 15:02:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 031A6E5F6 for ; Tue, 14 Jun 2022 15:02:46 +0200 (CEST) Received: from localhost ([::1]:49232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o16Bx-0004gE-4p for larch@yhetil.org; Tue, 14 Jun 2022 09:02:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o15xI-0000eI-HY for guix-devel@gnu.org; Tue, 14 Jun 2022 08:47:36 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:45318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o15xF-0005Sg-Tm; Tue, 14 Jun 2022 08:47:35 -0400 Received: by mail-wm1-x32d.google.com with SMTP id x6-20020a1c7c06000000b003972dfca96cso4737059wmc.4; Tue, 14 Jun 2022 05:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=izkWKOs5fAdbLdgoPMOfSnbik3NrwKQcSfLehii/wWI=; b=QkmKfsFv2xPMAK+KQicsToVKP2vhNVATEJtR5r0XOw34AYC47rVZP8eI2qeO5DpgyJ c10VXcS8Su+hLVERD3udTw+lgDYENhbjPzrm7a73E9Z2+S19YGCQOdKFWeuTL8cwETJI qloz5YqEQoZ4rHi0E5Nd6CRl7Jrz44K49D9y2POMLImCMyGX490EO7K5yku8z7elDQIa JpXvEYktt651BSE6BwXiPE0K6+NWxMLfaKBw785s890g5vKvXSxIxds7/F8Amdd2KR3T QXRu9/kbvfqBceuUhZS5KXbbk/I8LNIwXkC0iFMWo0DSOQXSeD7iaEX+AZ20zSr3CT9Y NTuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=izkWKOs5fAdbLdgoPMOfSnbik3NrwKQcSfLehii/wWI=; b=YPg/wGnq1MGioQSuZJTWywWo2TdYqSkARE5qBu8/Ko7uWzYPjMSsidJ773TC4OtAtV V82QF8sb8DeJDUzcBVR/7x2O1Jn2vZAAQSX90SBrl93LGK+cWDD7bJtK+/XkIrow382k YV8s9JxPYtqXzNjqXPUkQ7n9hnrHOIn7ZjVTsSPrVWfAQU2xWNDuUYVbI7dp20mHetGm AmVSts7a4g1b8IXM52MHRGMgKap7OBiPvjbJ8sG1KUDfdn9Wiqwh6W+5UOOj2eiuMhoY 3Fwft2JiNcAcl/nn31Pt2Y14onzSwRUn1G+W26qYU2Y+BTV/D9LKQpV18E9Us9VyN2gx eV0A== X-Gm-Message-State: AOAM531HHgziXgi7Y20DG5VOgd9+IiO2oHRGkKCU8rUCYmvS1x/t6d60 obSpczrTtX7u/ttGQG4zvZhyCtzhG5xNRg== X-Google-Smtp-Source: ABdhPJzoSxUowkvxjxWRZeFI4gy7gSpplU5o+8Nb971E9OccmZv9fbyHqq6wmWKXBv+NG7G4VGNW2Q== X-Received: by 2002:a1c:f701:0:b0:39c:5539:cc4f with SMTP id v1-20020a1cf701000000b0039c5539cc4fmr3970367wmh.163.1655210851653; Tue, 14 Jun 2022 05:47:31 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id t4-20020a05600001c400b0020e5b4ebaecsm11790058wrx.4.2022.06.14.05.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 05:47:31 -0700 (PDT) From: zimoun To: Thiago Jung Bauermann , Giovanni Biscuolo Cc: Arun Isaac , GNU Guix maintainers , guix-devel@gnu.org Subject: Re: On commit access, patch review, and remaining healthy In-Reply-To: <8735gb4xry.fsf@kolabnow.com> References: <87ee07m77w.fsf@gnu.org> <877d5um1oe.fsf@systemreboot.net> <87tu8viix0.fsf@xelera.eu> <87bkv1lipm.fsf@systemreboot.net> <87o7z0itz3.fsf@xelera.eu> <8735gb4xry.fsf@kolabnow.com> Date: Tue, 14 Jun 2022 13:54:19 +0200 Message-ID: <86ilp3cvf8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655211766; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=izkWKOs5fAdbLdgoPMOfSnbik3NrwKQcSfLehii/wWI=; b=e4k+VI/NBYDdToq3452w5DIEQM6zHUqfkMpfVlSyMEdioQdXAsyG1zCScvRcCU5GdVWpr2 9Sl6Fs/vVncfFMm4AE21ztz2lIg0Gq/J3nuuBdgOlt2Ntw7oN/7YRNHxM/qpLkf3AaGqUK 72vWH3bsUx+ULBbYwKr8ZnFo11hc2WmMgMO8XaGvCh7AtF7zXt7oXgzOZSTsWjzFgbB0x9 z8lDb7piLfXYOkR+UUvv3Tk6RN/fIC0x4bc8bbizvBncfGH8rptu4IqJkTUZwA3smaQPk2 zj/AF5WfvYCALJXlVj+4KX3UFzZL2EUwrRE0PeQ2BA/1kPYRcZAp9hfdotHvyQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655211766; a=rsa-sha256; cv=none; b=D1T2U2IMfdcuSnp+UMMsK4mTefli1iYhC00GsR40JW3WQlY4+oUylHyLAVbh/co15ajcOR JU+jyg2yL1EdpR2xJ8dt7gMBzy5E9lK5rmhty5p1njVYxstsknG95KDcuwjw1+AXRck05G aGZ2VgXLUOo8/AzQ6harHFCeAKMJhzvjrNHM5bLvbUe0jczVpNI0UPTMI3sKjpwlZPxVcj nsrtdp4sU0M87Dr7FABeKe3GVw4wvhW3wnwFTmQWuEzaK3L54YVVh9HJZPsw1Oidk2gV4b sAES66cJIYbSWmcTkgmFKTxaH+H6AqsWrfx6PjIEiZUzn0RtyAGgwQj9cvg7BQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QkmKfsFv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.99 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QkmKfsFv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 031A6E5F6 X-Spam-Score: -3.99 X-Migadu-Scanner: scn1.migadu.com X-TUID: QodoPeqS1iJb Hi, On Sat, 11 Jun 2022 at 01:13, Thiago Jung Bauermann wrote: > But I do think it's one more source of =E2=80=9Cfriction=E2=80=9D for new= contributors, > and one more thing for us to require that they get right. [...] > There's one in the GNU Coding Standards=C2=B9: [...] > Personally, I think nowadays this purpose is better fulfilled by > good commit messages and git blame. Especially with an editor that makes > it easy to use them to navigate through history (such as Emacs, but > certainly others as well). I agree that Emacs+Magit among many others make easy to navigate through the history. However, the commit messages are probably good enough because some Coding Standards are imposed. Because these standards, it is easy to navigate via grep for instance. Git blame is useful once you know exactly what you are looking for. Before that, when I try to figure out the logic behind such change, the commit messages more or less fixed by the standards are very helpful, IMHO. Whatever the style (ChangeLog or anything else), it appears to me a good thing to have strong standards. Cheers, simon