From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: [PATCH] gnu: moc: Update to 2.5.2. Date: Tue, 10 Jan 2017 20:07:47 -0500 Message-ID: <86h956z9ng.fsf@openmailbox.org> References: <86lguizbpt.fsf@openmailbox.org> <87k2a28l7t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cR7OT-0006Sp-5j for guix-devel@gnu.org; Tue, 10 Jan 2017 20:08:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cR7OO-0000xG-W9 for guix-devel@gnu.org; Tue, 10 Jan 2017 20:08:01 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:60372) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cR7OO-0000vy-Nc for guix-devel@gnu.org; Tue, 10 Jan 2017 20:07:56 -0500 In-Reply-To: <87k2a28l7t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Wed, 11 Jan 2017 02:00:06 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > Kei Kebreau writes: > >> Overdue update to moc 2.5.2. If it's reproducible for others as well, I'll >> commit it to master. >> From 389a7e8f02b800bc937a5f7e191d1d090c980401 Mon Sep 17 00:00:00 2001 >> From: Kei Kebreau >> Date: Tue, 10 Jan 2017 19:18:42 -0500 >> Subject: [PATCH] gnu: moc: Update to 2.5.2. >> >> * gnu/packages/music.scm (moc): Update to 2.5.2. >> --- >> gnu/packages/music.scm | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm >> index 59fd508f6..803e0a6e5 100644 >> --- a/gnu/packages/music.scm >> +++ b/gnu/packages/music.scm >> @@ -2179,7 +2179,7 @@ with a number of bugfixes and changes to improve IT playback.") >> (define-public moc >> (package >> (name "moc") >> - (version "2.5.1") >> + (version "2.5.2") >> (source (origin >> (method url-fetch) >> (uri (string-append "http://ftp.daper.net/pub/soft/" >> @@ -2187,7 +2187,13 @@ with a number of bugfixes and changes to improve IT playback.") >> name "-" version ".tar.bz2")) >> (sha256 >> (base32 >> - "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v")))) >> + "026v977kwb0wbmlmf6mnik328plxg8wykfx9ryvqhirac0aq39pk")) >> + (modules '((guix build utils))) >> + (snippet >> + ;; Remove use of __DATE__ and __TIME__ for reproducibility. >> + '(substitute* "main.c" >> + (("printf \\(\" Built : %s\", __DATE__\\);") "") >> + (("printf \\(\" %s\", __TIME__\\);") ""))))) > > The commit message should mention the change to [source]. I would prefer > if this was a separate patch, unless the __DATE__ and __TIME__ macros > were introduced in this version, but no strong opinion. > > LGTM! Thanks for the review! The macros you mention were indeed introduced in this version. I'll modify the commit message to include the changes to [source] and push it to master. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlh1hWMACgkQ5qXuPBlG eg12KxAAtE+VeWDFxNDOeFcqjPtrQpx+mH4IXgYMmwYNZSgbtAQfKZyZ2WbApV2D /ml9cziF7kKvLFIWn5ItwZ8QkHAwfOIsELJusAS5igljViZjKFeCdAFvCERuW5Yi 9ow9RTM42uJZnXux03sOiRnt9j44Qd+YOdZ268zQQZdKsiXlGeirHLoEJ2v9Yw2T HrPW7jT2FZsZWTaipVupMDMPb5USTQnsm1ZryRNBYeVqIw0I5dLVgmiJlt6ehraq vhQuhZxTXdGI07MWCQJ5/u4+0LIbQCmpe2O1TulvhpP+Epiwd+Xe5/xoWPGM5bWg SUre3bhOu8ZZ/oXAk1h9gMYnksXW5s/ZGzXiVQsodKcLBnDTPUTIkcHtfCOJofQz mLVbkfUOLgyyAKyJ1ZTEqt999Zf0sXtsUzfUbZEm6JLPwDROxmTYERLP4T8oxR8h vOO/y5kh22Zy9PcVhu+eS2fx3edTZs5KZksW0Tu3uSDZl08kmwGo5ZH9TBVFJCgy WLXvb4iugMBfNWQ/XeOmv+SNweFiQSVqAmgvHbO3PPQlkesG3ff0E1OP9Hn3/At3 Rd3JtG3aeU8iFURGCGAM97K0IzbJhMQ0+/Wq6eCHvorJCXm7Y+yHDXXxMIZVdAnR cjMACWci1LqPgK+xJ2CjTQsIwtRiihi7IcS38yzvYnd3B2hR6d0= =LXZk -----END PGP SIGNATURE----- --=-=-=--