From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aApbI0GHqGJQGAAAbAwnHQ (envelope-from ) for ; Tue, 14 Jun 2022 15:04:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eHslI0GHqGIxDgAAauVa8A (envelope-from ) for ; Tue, 14 Jun 2022 15:04:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2624F3BF97 for ; Tue, 14 Jun 2022 15:04:01 +0200 (CEST) Received: from localhost ([::1]:50396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o16DA-0005Wm-Ai for larch@yhetil.org; Tue, 14 Jun 2022 09:04:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o15xL-0000jU-AW for guix-devel@gnu.org; Tue, 14 Jun 2022 08:47:39 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:44930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o15xI-0005T6-GU; Tue, 14 Jun 2022 08:47:39 -0400 Received: by mail-wr1-x431.google.com with SMTP id q15so11098643wrc.11; Tue, 14 Jun 2022 05:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:date:message-id:mime-version :content-transfer-encoding; bh=nuup92eZDqX4jH+z/FPVMv2d9NvRpsudvJfnxcjFi7E=; b=mApXe0fH7ORVMRO4cMAdZnMU8AZktIzALjGg3036SQlYjwY1EZ///wNFpGWvX+D6Cb U8M9/2EbUui31JL4NYk3q6cYHOH6c1Pa9/4stEvPSDuxq9WZTE5mgSAt1yujs2PdTvnB mWBnWQKNUv4niYFDLxCbwzi+2mUgLlKSVr37/HgoHiNtSx8zKH97vCnvDm6mcf5sdZd2 F/sW1+m3lX5WagLUrPfmeNaJIAjP07prQhMfAjtDmRbSiUDjx2tWitBEDztJfEUS32m5 Vkmj/JLk0ljTMOooUH0f0wz5AQnkZ+TsdD7CMbQVpy551M744XJvQB3qJI55WBPiaa4O QYRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-transfer-encoding; bh=nuup92eZDqX4jH+z/FPVMv2d9NvRpsudvJfnxcjFi7E=; b=vzYkQyL78/i7wPU8gj61QN84H8G0XeWK1jZuMa7mFNuOidDIvTHlDuRI838ExmCNbY OqLq6D1Wnn1rwTW92M2mncoUKpPZW+1O7wN3FqDIG5qbgVPZZzltU3rm2RFEPmMZ2sUM lHW4j2Dw8n25HAuOy7QfnX9/pjin93+B7HW4skoqWpiJmJ99x7G+15DzDfBNNdJUwOx3 mFHZgunxzBMMia3+7B4gOc2FVxkY7yoxCfz0CykHcTWxvxq+z/sVNVb44qbcweh+P6tW wVmHekZzod7QAGIl+aM3a6NAmc1TTRXOMLTGMtoAxfGmKajd/GEdEqCt8bV9tdS2E/Cs 5Q8Q== X-Gm-Message-State: AJIora/IQ3Ikp3JVV+lp45mNxIyZbUS20Ys4Ok3R6cfTOuzb7ki+OkBf tPRcki1z+TgpMK4LQRwxp2bcib9XWsC/Rw== X-Google-Smtp-Source: AGRyM1sNUEsoInYHfbRTMvVUTs5FUjT5UU5CnJR5k3TBD8XaUrV55KkzIuCtEaGKAHeEIBS1Fqb4Sg== X-Received: by 2002:a5d:45c3:0:b0:216:973c:328e with SMTP id b3-20020a5d45c3000000b00216973c328emr4789057wrs.176.1655210853728; Tue, 14 Jun 2022 05:47:33 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id i11-20020a05600c354b00b003942a244f47sm17423971wmq.32.2022.06.14.05.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 05:47:33 -0700 (PDT) From: zimoun To: Giovanni Biscuolo , Ludovic =?utf-8?Q?Court=C3=A8s?= , Arun Isaac Cc: Guix Devel , GNU Guix maintainers Subject: Re: On commit access, patch review, and remaining healthy In-Reply-To: <87wndrijtq.fsf@xelera.eu> Date: Tue, 14 Jun 2022 14:24:09 +0200 Message-ID: <86fsk7cu1i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655211841; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=nuup92eZDqX4jH+z/FPVMv2d9NvRpsudvJfnxcjFi7E=; b=B01s45lHNotiKiuO+1aHTqmbJGG9HSI4oYR1tAcXkJAWK9G9xALkCiIdcEypVz+9tCt2hI DRD9NmeOkL5Y8ZEseb1GALUz3TSIRuo83GoUhnVHyUKgBFRxx2q5vQTbp2Fdi5nJCMEKsY c8KpAPRtSV0PYS6ONG4fOqKNNfqdhodN3OaufIL6Q61ZroT3k0VXEX6dL506i45kE1Uhg/ LlfLmfcSVaJfgdSnj+9YkH1OqZrIGZMIpDwoRi+I6TGYHsQsdvrstdLckejdzyeMMI/52P KGmTQWV37VPhxU2/rAc0ivMjclPCpmD1yqCB+QfwuTqWyaMa0OP30/M0wFZTdA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655211841; a=rsa-sha256; cv=none; b=tqXnaLkBATQTIfIHjVTxwZkdb4LpLUpUECZC2cCqD9Dg2zYHAun6B8kkF4x4oy+5JWTQsw RQJ2E/1SpWBi0lg1hypQmFmJ3FYAGpRqy1ZgCTg0cgoxsDRiKhYR4QxYg2Zi8+uYN2AJ8+ CjHlFGCmMk0ij4dsnqxF5u/uioA3dz8V0PzKHOMlS4MKzAYo+FfGGPh/lsKhLgBt0htijy JBqTvr0m7B2rl716UCYpIYn3jvw94hZkLazEeetMULw3iJFed/0R1tp+2cZM+2G6pXDqhl dJym1ede/vluhSKPpFPpIsDXI3CQmBGd9Ozv+6xDdksIR3Nu3874VPHonjCeQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mApXe0fH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.99 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mApXe0fH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2624F3BF97 X-Spam-Score: -3.99 X-Migadu-Scanner: scn1.migadu.com X-TUID: li7gtSMrXjJv Hi, On Wed, 08 Jun 2022 at 11:30, Giovanni Biscuolo wrote: >> It reduces a bit the pressure on the committers, IMHO. > > It raises a bit the pressure on the maintainers, IMHO :-) What does it mean =E2=80=9Cmaintainer=E2=80=9D here? Maybe I miss something but I do not think the Guix maintainers play a special role in reviewing or committing. Could you explain which pressure you are envisioning? > I understand there is a certain "entrance barrier" to become patch > reviewer, but I'm afraid we cannot lower it more than the current > situation except for the offload build server and more tolling options. I am missing the meaning of =C2=ABtolling option=C2=BB. I think it is possible to lower a bit the reviewing barrier. Today, the patch submission is very flexible: it is possible to send inline patches, attached patches, mix inline and attach, subject can or not contain =E2=80=99vN=E2=80=99 and/or X/Y, base-commit is recommended but not= mandatory, etc. Therefore, it is hard to automate many reviewing steps. For instance, consider submission #47171 [1]. It was not my first contribution, it was not the first review by Ricardo, and we both missed a =E2=80=9Cguix pull=E2=80=9D breakage despite the fact I did =E2=80=9Cmake= as-derivation=E2=80=9D (and I am not convinced it is systematically done ;-)). Another example, when working of Preservation of Guix [2], I noticed that many packages using git-fetch were not in SWH; which means that =E2=80=9Cguix lint=E2=80=9D had not been run on these packages. We could answer more automated tools on infra side, etc. which is the direction to go. But we are not there yet and things need to be done today. :-) That=E2=80=99s why, I think the project should: 1. change the default branch of =E2=80=9Cgit push=E2=80=9D vs the default = branch of =E2=80=9Cguix pull=E2=80=9D. 2. add a bit more of checkers on patch submission easing patch review. =20 1: 2: Cheers, simon