From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UGOYE4slw2GdlwAAgWs5BA (envelope-from ) for ; Wed, 22 Dec 2021 14:18:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qHBfD4slw2H4fgAA1q6Kng (envelope-from ) for ; Wed, 22 Dec 2021 13:18:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA43132320 for ; Wed, 22 Dec 2021 14:18:02 +0100 (CET) Received: from localhost ([::1]:39920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n01VJ-0005gd-Ve for larch@yhetil.org; Wed, 22 Dec 2021 08:18:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n01Od-0002Ix-II for guix-devel@gnu.org; Wed, 22 Dec 2021 08:11:08 -0500 Received: from [2a00:1450:4864:20::42c] (port=40690 helo=mail-wr1-x42c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n01Ob-0008Fv-5j for guix-devel@gnu.org; Wed, 22 Dec 2021 08:11:07 -0500 Received: by mail-wr1-x42c.google.com with SMTP id q16so4830284wrg.7 for ; Wed, 22 Dec 2021 05:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=qpKSyd1/RuPNtPjK/daTZfqDaCUrLhbc2O64iMhewOI=; b=jJDMytnsiUoCfW5UXTuoFpEZ23rXqKZq5MXEcH6TR7r/Q5uYuI91De37zVwKFT4DDI O88AWnZYrOfSEHFw0icnwr2j3v81ztmjqt9kCL0DCEhIV3Qp8sfAGmPfu2dxzpNTw+oX EbYTyp1ifynX5/NI43xp9Vyu0Xmi+6aSYMOnC0iawkT580MWuqre+zerSy1abZNBLvH3 b6cbcTvUhIzk3DPKjwLZmXQEyuZTPpJBwjv2qMF+a8SM8DDVwM6xCCaXW5aCG9GgybtS +tmPexmRnHASqHG2v86HRGKqDtN6zA41nVOeiDIIw95M4MkgW8wDoAtzGcvnlTdPD+Nx WhyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=qpKSyd1/RuPNtPjK/daTZfqDaCUrLhbc2O64iMhewOI=; b=PwyjlAAQE+5KCtGiyyd//1pB3MFECat5rAMOAaGIy8u6NFWWUz/TsRedKQ4Mn5SmEH B1XPk9O2f7VtBhgIOqEaX9ZWSVNRrYSh63g3HrSvCu4Zma+5mwjsDjhJ+oVUiEEs5AI2 SbsSkS63HNiPHHICxbe+e5fkp9FOc37y5ag/F8KsFY1ieW49qHtEVL9JZkQ7vKIg+gK1 EgND2IxfUNE5XhWAJHn/UVKdP3KW0xJefPe4ow4I3ymVDIIPWetCD7VoxMF/HvMIy+2u W3M9k9A7HHZbUWFetNeqB89nrNgq43ccIhz1lX/1R5nRwLNzpwuHgfZTZpPZySzbbqj/ FFcQ== X-Gm-Message-State: AOAM531F262Ik7bJ8XDJu95ihxn/QWi3tiP+t638Lao3BcqibMO8mOZb ED5sBk9nC7uF9vC6nbIvoSK75iodmR4= X-Google-Smtp-Source: ABdhPJxkkhRnClxgLdwegQO20xFtIFnCJNw0fHrC8KsffXBFSNwF3Tk03nmpjpUDE60i3c1HM2l0DQ== X-Received: by 2002:a5d:47a3:: with SMTP id 3mr2017545wrb.583.1640178663233; Wed, 22 Dec 2021 05:11:03 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id e18sm2143770wrx.36.2021.12.22.05.11.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 05:11:02 -0800 (PST) From: zimoun To: Guix Devel Subject: Convention for new =?utf-8?Q?=E2=80=9Cguix_style=E2=80=9C=3F?= Date: Wed, 22 Dec 2021 14:05:06 +0100 Message-ID: <86bl18sscd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42c (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640179083; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=qpKSyd1/RuPNtPjK/daTZfqDaCUrLhbc2O64iMhewOI=; b=NzuV5vHKIL/gKVjwO9HSUYQSdCn7vaxVS9bAeh2jSMuWIwb6ttFPhjXPnhHOfwWvK3VgPO wOajduDP4U5UdYGK7ex3kfITVoQwmenl0U/0cLBsWIZ4rjjZfnfqY09cprrkomPMdffBPY 5Ru0y7KAZcyYUcOl04iDJKvSVMjoCDHQeC2o3SGdJHjYNDy2irT0GpXXAA7IXGNs+Cn+Xo Qv4ek+RneTbFf+tgf3Z9f2NPU+9EsbznbV9xHVelhle7BqcbenEwIXn+FKPJI3LaRcTv4Y 6N85pRZ22JDLMERV1L2g1XwZ7HAY53qTKROdUY+wvFogTqz1bicbZPPwpywtgQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640179083; a=rsa-sha256; cv=none; b=p3dCusOf+o7Zbo0ySjSAQIMc1FEf7cGFRJ5OqjXdQ3zGnaHUaKaIUQMAgOWI2HdjLrSw9M 3pHuZzF0GX+iWlGO8MqlfnCHKQd5hkN2j5Y3Z2aa/y22jrRuavkbZYEGgQCm/j2oEUBXdn Q5pcMd6uiyRH2WUSP3q/H/hP3TZJUOz2mtNbiIatGgbnKBrYu3yTwA3AIXN23WNjG1Pq8P Pk6LFzzBOG5jVZHXM1+V3LsDYu55p0CzArpd8g1MkmYkjEuKntE4Bvxd4g+LcHLLCP25TQ LvtG4pBIjTrtWkONcvnpPd4C0CFXvO58YnfLDOmmJUnKyFgGNodlHrY/gFjbwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jJDMytns; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.54 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jJDMytns; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DA43132320 X-Spam-Score: -8.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: fVenXTs/keqo Hi, This could be part of a RFC process. :-) The Big Change introduces new style, other said, this old --8<---------------cut here---------------start------------->8--- (native-inputs `(("perl" ,perl) ("pkg-config" ,pkg-config))) --8<---------------cut here---------------end--------------->8--- is replaced by this new, --8<---------------cut here---------------start------------->8--- (native-inputs (list perl pkg-config)) --8<---------------cut here---------------end--------------->8--- It removes all the labels. \o/ More details [1]. We had a discussion on IRC starting here [2]. This proposal is to document in the manual and adapt =E2=80=98guix style=E2=80=99 to have one i= nput per line =E2=80=93 as it was the case with the old style. Aside preference, for instance, I find easier to read, --8<---------------cut here---------------start------------->8--- (inputs ;required for test (list julia-chainrulestestutils julia-finitedifferences julia-nanmath julia-specialfunctions)) (propagated-inputs (list julia-chainrulescore julia-compat julia-reexport julia-requires)) --8<---------------cut here---------------end--------------->8--- than --8<---------------cut here---------------start------------->8--- (inputs ;required for test (list julia-chainrulestestutils julia-finitedifferences julia-nanmath julia-specialfunctions)) (propagated-inputs (list julia-chainrulescore julia-compat julia-reexport julia-requires)) --8<---------------cut here---------------end--------------->8--- but this is somehow bikeshed. However, the current situation leads to non-uniform or ambiguity. For example, the comments as here: --8<---------------cut here---------------start------------->8--- (inputs (list libx11 libiberty ;needed for objdump support zlib)) ;also needed for objdump support --8<---------------cut here---------------end--------------->8--- when the comments apply to only one line as it was: --8<---------------cut here---------------start------------->8--- `(("libx11" ,libx11) ("libiberty" ,libiberty) ;needed for objdump support ("zlib" ,zlib))) ;also needed for objdump supp= ort --8<---------------cut here---------------end--------------->8--- Other said, this looks better: --8<---------------cut here---------------start------------->8--- (inputs (list libx11 libiberty ;needed for objdump support zlib)) ;also needed for objdump support --8<---------------cut here---------------end--------------->8--- Obviously, we could come up a rule depending on comments, numbers of inputs, length, etc. It was not the case with the old style when nothing prevented us to do it. Because one item per line is, IMHO, easier to maintain. Consider the case, (inputs (list bar foo1 foo2 foo3 foo3 foo4)) then another =E2=80=99baz=E2=80=99 inputs is added, do we end with, (inputs (list bar foo1 foo2 foo3 foo3 foo4 baz)) to minimize and ease reading the diff, or do we end with, (inputs (list bar baz foo1 foo2 foo3 foo3 foo4)) ? And the converse is also true, consider the case just above and what happens if foo1, foo2 and foo3 are removed. One item per line solves all these boring cosmetic questions. Therefore, I propose to always have only one item per line. To be concrete, for one item: (inputs (list foo)) or not (inputs (list foo)) And for more than one item: (inputs (list foo bar)) This would avoid =E2=80=9Ccosmetic=E2=80=9D changes when adding/removing in= puts and/or comments. Sadly, it implies another Big Change. But earlier is better and we should do it as soon as possible while the conversion is not totally done yet. Cheers, simon 1: 2: