From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uO/rERcT6mOAfAEAbAwnHQ (envelope-from ) for ; Mon, 13 Feb 2023 11:38:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IAcIEhcT6mNuhgAA9RJhRA (envelope-from ) for ; Mon, 13 Feb 2023 11:38:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 780E535D43 for ; Mon, 13 Feb 2023 11:38:14 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WcDDmqAo; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676284695; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=0Xm8lcuzTI1+KeZG4/Pr7H3avJ57OkAf3R/2E3gWhKI=; b=Yl4JDCDhQmYY8apZ1cp/WdNtC9VwZrhPbBy3EF1woeTIKp2XN49pLd9tU0lnxw/ANa1wo6 wGncz2RfqsCrdm1Hppk3HN3XP2JccSNjvoaF+9Rf3CowtX7/avl4js2K24F5eU6147T+Fr iNbJDt4zpx3jsZD8LvlfuRwDss1s0nXZYhLkbB3z3qSxpYl136mvvTtrLHkFvNkZ6lpHQL QsHaE6Hsz6GcQ2daaDc64T/ivRRt+9/PX8pRr7U6OFki+YKPeauH0Vz5P5JqqFdsptjrf2 i0g6N3tIyLgsUBllnA4+rVSpnyXId/rcZA69DEiusF6iJbSgFgllpUcd171CIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WcDDmqAo; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676284695; a=rsa-sha256; cv=none; b=P/UFyaVUzpTIZToNmxOpBugqbx4N7KyOR0estqVVcpVtlqU4Soy/rODx1JciE+5MA1jEtS uTxM5RvpuEc8sLFdi/OBfn4YcAxwv1bTGsihCSg7AWmQWkD96KIziweHHU8wdzg+3VmdKi OLxPwfjki12uDeat01zJOarxIhrt+hWX785dZAKRcw8ikocAq87PbOsM2EbDgFr/N+oicr wZOHjWZV5jdepiLVUm8kgMj/l+UF8LdrZq6FRFL6bJ9pUkZgG78lezRvEC2EunxqTJwbIi DNXy/uhB59W47kycCN0vt1TRaaox7y9ZiJWh4SeEA9DNDzuBLoKQxYXSH0efxA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRWDU-0004nR-9I; Mon, 13 Feb 2023 05:37:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRWDS-0004mf-NQ for guix-devel@gnu.org; Mon, 13 Feb 2023 05:37:46 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRWDN-00063J-P6; Mon, 13 Feb 2023 05:37:43 -0500 Received: by mail-wm1-x332.google.com with SMTP id o36so8379734wms.1; Mon, 13 Feb 2023 02:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1676284654; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0Xm8lcuzTI1+KeZG4/Pr7H3avJ57OkAf3R/2E3gWhKI=; b=WcDDmqAo83U7ZskXyvjAginjQ4SX7k4OcRVX4qz+1rcqoKeej1yGoq7vTqylbLReqq vzVGxzdOOR4hJwDQPsrUpAnKEZ8PY7VC3GeAlcw7tuMPU8rmSX57udj6FCxBjbXf8KjA NfpZpTB/XK60TRrnM+iDb9Hderu5iySpxjMGaRcCJH3idpj3GJw63iVFA2OVh61Ir19D n1zb9R9zYeql0ysFv2H3EoLuecR9dx2W3s5/h1cqziEdqTVOl/ZcWdbkb+KE9OItZqm/ DRQpdvij+7rmXxN2Q/yuHcBHFxpCxecxO8bBdf+Zc5XGYxVPhQddeR+DuBhKXgxU2XMZ TZeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676284654; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Xm8lcuzTI1+KeZG4/Pr7H3avJ57OkAf3R/2E3gWhKI=; b=KLZxLjlrPP5NYInRscH1CBLU/kW/9J2VmPjYRIzZE6uVP3JEMeJHTN08Rmqeu/F1w8 JjWzupibiHC0Aba2cymA7wVOEtgPpQEl/CCiZypPRn32UxwzD/pRxleDNbgTmlhTWTr0 BB+b9UMF7yit3imFVx8hwvm99FHHLkRntWjfAwq6z2t544mIeSys95Qxyx6b8crqyriz aqEX2wAwilzFw47gKG2BgV/3XQqclLWVkVqIOKJfGWoQRCnBG7bIr3sEEV7v7o/IfWnk mVJ2NLcbTPFB4uFruaqu34uj34GTkDi8diG/vHSLeQHzIdZMVjfdN/y8JpHMe6QZQzVq 5K2g== X-Gm-Message-State: AO0yUKXhT2mScEeTyeeK9zOMc6+fuBtJcGL2jmTR1JVlX4cfP3+sCVLM bASLIjfFSkEE2gkZBJGkdg4Y6qYSFSw= X-Google-Smtp-Source: AK7set/xk7f+DTSH0YrS8iF/Qajes9NSn/Fl3pCA/PYe4En7jmwtd1wgMBS73EBBuGV9i572R6Ry8w== X-Received: by 2002:a05:600c:354a:b0:3dc:5764:c164 with SMTP id i10-20020a05600c354a00b003dc5764c164mr22502042wmq.4.1676284654248; Mon, 13 Feb 2023 02:37:34 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id y6-20020a05600c364600b003df7b40f99fsm16001838wmq.11.2023.02.13.02.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 02:37:33 -0800 (PST) From: zimoun To: Ludovic =?utf-8?Q?Court=C3=A8s?= , "Nicolas Graves via Development of GNU Guix and the GNU System distribution." Cc: Nicolas Graves Subject: Re: avoid Computing Guix derivation when not necessary In-Reply-To: <87ilg7n3p9.fsf@gnu.org> References: <87v8k9bqk4.fsf@ngraves.fr> <87ilg7n3p9.fsf@gnu.org> Date: Mon, 13 Feb 2023 11:37:18 +0100 Message-ID: <86bklx7swx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: X-Migadu-Queue-Id: 780E535D43 X-Spam-Score: -9.82 X-Migadu-Spam-Score: -9.82 X-Migadu-Scanner: scn0.migadu.com List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: NsC0GL0JLmXr Hi, On Sun, 12 Feb 2023 at 01:10, Ludovic Court=C3=A8s wrote: >> The principle is simple: get commit and directory info from the profile >> manifest, compare commits, if commits for all channels are the same, do >> not try to update the profile. Indeed, some improvements could be done in that direction. For instance, --8<---------------cut here---------------start------------->8--- $ guix describe Generation 89 Jan 17 2023 15:20:08 (current) guix 29efa27 repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: 29efa2791dafb042ca8ace77bcf8538fb404d492 $ guix pull --commit=3D29efa27 Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.or= g/git/guix.git'... Building from this channel: guix https://git.savannah.gnu.org/git/guix.git 29efa27 Computing Guix derivation for 'x86_64-linux'... | [...] --8<---------------cut here---------------end--------------->8--- Going from one commit to the exact same commit should not trigger some intensive =C2=ABComputing Guix derivation=C2=BB. Note that if I run =E2=80=9Cguix pull --commit=3D29efa27=E2=80=9D two times= in row, the second one it displays: =C2=ABnothing to be done=C2=BB after =C2=ABComputin= g Guix derivation=C2=BB. Last, note that: /var/guix/profiles/per-user/simon/current-guix -> current-guix-90-link and --8<---------------cut here---------------start------------->8--- $ /var/guix/profiles/per-user/simon/current-guix-90-link/bin/guix describe guix 29efa27 repository URL: https://git.savannah.gnu.org/git/guix.git commit: 29efa2791dafb042ca8ace77bcf8538fb404d492 $ /var/guix/profiles/per-user/simon/current-guix-89-link/bin/guix describe guix 29efa27 repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: 29efa2791dafb042ca8ace77bcf8538fb404d492 $ readlink -f /var/guix/profiles/per-user/simon/current-guix-90-link /gnu/store/g32zjrbr40fzp1rj5i6gx7hal20myfyv-profile $ readlink -f /var/guix/profiles/per-user/simon/current-guix-89-link /gnu/store/pk1i1dsagdby5pqydmvfbffg0i80wwvy-profile $ diff -r --no-dereference \ /gnu/store/g32zjrbr40fzp1rj5i6gx7hal20myfyv-profile/manifest \ /gnu/store/pk1i1dsagdby5pqydmvfbffg0i80wwvy-profile/manifest 12c12 < "/gnu/store/96bibk75vy5yvmilnycd8pl0l2bydcww-guix-29efa2791" --- > "/gnu/store/ldp0snjsac6hp1fikk5b8413pihm77di-guix-29efa2791" 20c20 < (branch #f) --- > (branch "master") --8<---------------cut here---------------end--------------->8--- Hum, maybe I have something twisted somewhere in my configuration. From my understanding, it comes from (guix scripts pull): --8<---------------cut here---------------start------------->8--- (match (find guix-channel? channels) ((? channel? guix) ;; Apply '--url', '--commit', and '--branch' to the 'guix' chann= el. (let ((url (or url (channel-url guix)))) (cons (match ref (('commit . commit) (channel (inherit guix) (url url) (commit commit) (branch #f))) --8<---------------cut here---------------end--------------->8--- where =E2=80=99branch=E2=80=99 should not be #f but instead inherit from = =E2=80=99guix=E2=80=99. I remember discussing this but I do not find where. :-) > One marginal improvement would be sharing the cache that =E2=80=98time-ma= chine=E2=80=99 > uses with =E2=80=98guix pull=E2=80=99. Last I looked it wasn=E2=80=99t a= s easy as one might > hope, but I forgot the details. It could be nice! :-) Last time I gave a look, I had an headache. ;-) Cheers, simon